Skip to content

Commit f87bd40

Browse files
author
Om Sharma
authored
Merge pull request #48 from clouddrove/fix/comments
fix: Standardize Comments
2 parents d6406d7 + 7fd25eb commit f87bd40

File tree

14 files changed

+110
-110
lines changed

14 files changed

+110
-110
lines changed

‎.github/workflows/auto_assignee.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
workflow_dispatch:
66
jobs:
77
assignee:
8-
uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@1.0.5
8+
uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@1.0.6
99
secrets:
1010
GITHUB: ${{ secrets.GITHUB }}
1111
with:

‎.github/workflows/changelog.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
workflow_dispatch:
88
jobs:
99
changelog:
10-
uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@1.0.5
10+
uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@1.0.6
1111
secrets: inherit
1212
with:
1313
branch: 'master'

‎.github/workflows/tf-checks.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,34 @@ on:
66
workflow_dispatch:
77
jobs:
88
tf-checks-complete-example:
9-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
9+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
1010
with:
1111
working_directory: './_example/complete/'
1212
tf-checks-cors_s3-example:
13-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
13+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
1414
with:
1515
working_directory: './_example/cors_s3/'
1616
tf-checks-default-s3-example:
17-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
17+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
1818
with:
1919
working_directory: './_example/default-s3/'
2020
tf-checks-encryption-s3-example:
21-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
21+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
2222
with:
2323
working_directory: './_example/encryption-s3/'
2424
tf-checks-logging-encryption-s3-example:
25-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
25+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
2626
with:
2727
working_directory: './_example/logging-encryption-s3/'
2828
tf-checks-logging-s3-example:
29-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
29+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
3030
with:
3131
working_directory: './_example/logging-s3/'
3232
tf-checks-s3-replication-example:
33-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
33+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
3434
with:
3535
working_directory: './_example/s3-replication/'
3636
tf-checks-website-s3-example:
37-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.5
37+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
3838
with:
3939
working_directory: './_example/website-s3/'

‎.github/workflows/tflint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ on:
66
workflow_dispatch:
77
jobs:
88
tf-lint:
9-
uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@1.0.5
9+
uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@1.0.6
1010
secrets:
1111
GITHUB: ${{ secrets.GITHUB }}

‎.github/workflows/tfsec.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
workflow_dispatch:
66
jobs:
77
tfsec:
8-
uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@1.0.5
8+
uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@1.0.6
99
secrets: inherit
1010
with:
1111
working_directory: '.'

‎_example/complete/example.tf

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
##-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
##-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -12,9 +12,9 @@ locals {
1212
}
1313

1414
data "aws_canonical_user_id" "current" {}
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
## Provides details about a specific S3 bucket.
17-
##----------------------------------------------------------------------------------
17+
##-----------------------------------------------------------------------------
1818
module "logging_bucket" {
1919
source = "./../../"
2020

@@ -49,9 +49,9 @@ module "subnets" {
4949
ipv6_cidr_block = module.vpc.ipv6_cidr_block
5050
}
5151

52-
##----------------------------------------------------------------------------------
52+
##-----------------------------------------------------------------------------
5353
## Below resources will create KMS-KEY and its components.
54-
##----------------------------------------------------------------------------------
54+
##-----------------------------------------------------------------------------
5555
module "kms_key" {
5656
source = "clouddrove/kms/aws"
5757
version = "1.3.1"
@@ -67,9 +67,9 @@ module "kms_key" {
6767
policy = data.aws_iam_policy_document.default.json
6868
}
6969

70-
##----------------------------------------------------------------------------------
70+
##-----------------------------------------------------------------------------
7171
## Generates an IAM policy document in JSON format for use with resources that expect policy documents such as aws_iam_policy.
72-
##----------------------------------------------------------------------------------
72+
##-----------------------------------------------------------------------------
7373
data "aws_iam_policy_document" "default" {
7474
version = "2012-10-17"
7575
statement {
@@ -84,9 +84,9 @@ data "aws_iam_policy_document" "default" {
8484
}
8585
}
8686

87-
##----------------------------------------------------------------------------------
87+
##-----------------------------------------------------------------------------
8888
## Provides details about a specific S3 bucket.
89-
##----------------------------------------------------------------------------------
89+
##-----------------------------------------------------------------------------
9090
module "s3_bucket" {
9191
source = "./../../"
9292

‎_example/cors_s3/example.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -10,9 +10,9 @@ locals {
1010
label_order = ["name", "environment"]
1111
}
1212

13-
##----------------------------------------------------------------------------------
13+
##-----------------------------------------------------------------------------
1414
## Provides details about a specific S3 bucket.
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
module "s3_bucket" {
1717
source = "./../../"
1818

‎_example/default-s3/example.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -10,9 +10,9 @@ locals {
1010
label_order = ["name", "environment"]
1111
}
1212

13-
##----------------------------------------------------------------------------------
13+
##-----------------------------------------------------------------------------
1414
## Provides details about a default S3 bucket.
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
module "s3_bucket" {
1717
source = "./../../"
1818

‎_example/encryption-s3/example.tf

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -10,9 +10,9 @@ locals {
1010
label_order = ["name", "environment"]
1111
}
1212

13-
##----------------------------------------------------------------------------------
13+
##-----------------------------------------------------------------------------
1414
## Below resources will create KMS-KEY and its components.
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
module "kms_key" {
1717
source = "clouddrove/kms/aws"
1818
version = "1.3.1"
@@ -28,9 +28,9 @@ module "kms_key" {
2828
policy = data.aws_iam_policy_document.default.json
2929
}
3030

31-
##----------------------------------------------------------------------------------
31+
##-----------------------------------------------------------------------------
3232
## Generates an IAM policy document in JSON format for use with resources that expect policy documents such as aws_iam_policy.
33-
##----------------------------------------------------------------------------------
33+
##-----------------------------------------------------------------------------
3434
data "aws_iam_policy_document" "default" {
3535
version = "2012-10-17"
3636
statement {
@@ -45,9 +45,9 @@ data "aws_iam_policy_document" "default" {
4545
}
4646
}
4747

48-
##----------------------------------------------------------------------------------
48+
##-----------------------------------------------------------------------------
4949
## Provides details about a specific S3 bucket.
50-
##----------------------------------------------------------------------------------
50+
##-----------------------------------------------------------------------------
5151
module "s3_bucket" {
5252
source = "./../../"
5353

‎_example/logging-encryption-s3/example.tf

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -10,9 +10,9 @@ locals {
1010
label_order = ["name", "environment"]
1111
}
1212

13-
##----------------------------------------------------------------------------------
13+
##-----------------------------------------------------------------------------
1414
## Provides details about a logging S3 bucket.
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
module "logging_bucket" {
1717
source = "./../../"
1818

@@ -23,9 +23,9 @@ module "logging_bucket" {
2323
acl = "log-delivery-write"
2424
}
2525

26-
##----------------------------------------------------------------------------------
26+
##-----------------------------------------------------------------------------
2727
## Below resources will create KMS-KEY and its components.
28-
##----------------------------------------------------------------------------------
28+
##-----------------------------------------------------------------------------
2929
module "kms_key" {
3030
source = "clouddrove/kms/aws"
3131
version = "1.3.1"
@@ -41,9 +41,9 @@ module "kms_key" {
4141
policy = data.aws_iam_policy_document.default.json
4242
}
4343

44-
##----------------------------------------------------------------------------------
44+
##-----------------------------------------------------------------------------
4545
## Generates an IAM policy document in JSON format for use with resources that expect policy documents such as aws_iam_policy.
46-
##----------------------------------------------------------------------------------
46+
##-----------------------------------------------------------------------------
4747
data "aws_iam_policy_document" "default" {
4848
version = "2012-10-17"
4949
statement {
@@ -58,9 +58,9 @@ data "aws_iam_policy_document" "default" {
5858
}
5959
}
6060

61-
##----------------------------------------------------------------------------------
61+
##-----------------------------------------------------------------------------
6262
## Provides details about a specific S3 bucket.
63-
##----------------------------------------------------------------------------------
63+
##-----------------------------------------------------------------------------
6464
module "s3_bucket" {
6565
source = "./../../"
6666

‎_example/logging-s3/example.tf

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -10,9 +10,9 @@ locals {
1010
label_order = ["name", "environment"]
1111
}
1212

13-
##----------------------------------------------------------------------------------
13+
##-----------------------------------------------------------------------------
1414
## Provides details about a logging S3 bucket.
15-
##----------------------------------------------------------------------------------
15+
##-----------------------------------------------------------------------------
1616
module "logging_bucket" {
1717
source = "./../../"
1818

@@ -23,9 +23,9 @@ module "logging_bucket" {
2323
acl = "log-delivery-write"
2424
}
2525

26-
##----------------------------------------------------------------------------------
26+
##-----------------------------------------------------------------------------
2727
## Provides details about a specific S3 bucket.
28-
##----------------------------------------------------------------------------------
28+
##-----------------------------------------------------------------------------
2929
module "s3_bucket" {
3030
source = "./../../"
3131

‎_example/s3-replication/example.tf

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
####----------------------------------------------------------------------------------
1+
####-----------------------------------------------------------------------------
22
## Provider block added, Use the Amazon Web Services (AWS) provider to interact with the many resources supported by AWS.
3-
####----------------------------------------------------------------------------------
3+
####-----------------------------------------------------------------------------
44
provider "aws" {
55
region = "eu-west-1"
66
}
@@ -17,18 +17,18 @@ locals {
1717
label_order = ["name", "environment"]
1818
}
1919

20-
##----------------------------------------------------------------------------------
20+
##-----------------------------------------------------------------------------
2121
## Below resources will create KMS-KEY and its components.
22-
##----------------------------------------------------------------------------------
22+
##-----------------------------------------------------------------------------
2323
resource "aws_kms_key" "replica" {
2424
provider = aws.replica
2525
description = "S3 bucket replication KMS key"
2626
deletion_window_in_days = 7
2727
}
2828

29-
##----------------------------------------------------------------------------------
29+
##-----------------------------------------------------------------------------
3030
## Provides details about a replica S3 bucket.
31-
##----------------------------------------------------------------------------------
31+
##-----------------------------------------------------------------------------
3232
module "replica_bucket" {
3333
source = "../../"
3434

@@ -42,9 +42,9 @@ module "replica_bucket" {
4242
acl = "private"
4343
versioning = true
4444
}
45-
##----------------------------------------------------------------------------------
45+
##-----------------------------------------------------------------------------
4646
## Provides details about a specific S3 bucket.
47-
##----------------------------------------------------------------------------------
47+
##-----------------------------------------------------------------------------
4848
module "s3_bucket" {
4949
source = "../../"
5050

@@ -137,9 +137,9 @@ module "s3_bucket" {
137137
}
138138
}
139139

140-
##----------------------------------------------------------------------------------
140+
##-----------------------------------------------------------------------------
141141
## Provides an IAM role.
142-
##----------------------------------------------------------------------------------
142+
##-----------------------------------------------------------------------------
143143
resource "aws_iam_role" "replication" {
144144
name = "s3-bucket-replication-${module.replica_bucket.id}"
145145

@@ -160,9 +160,9 @@ resource "aws_iam_role" "replication" {
160160
POLICY
161161
}
162162

163-
##----------------------------------------------------------------------------------
163+
##-----------------------------------------------------------------------------
164164
## Generates an IAM policy in JSON format for use with resources that expect policy documents such as aws_iam_policy.
165-
##----------------------------------------------------------------------------------
165+
##-----------------------------------------------------------------------------
166166
resource "aws_iam_policy" "replication" {
167167
name = "s3-bucket-replication-${module.replica_bucket.id}"
168168

@@ -203,9 +203,9 @@ resource "aws_iam_policy" "replication" {
203203
POLICY
204204
}
205205

206-
##----------------------------------------------------------------------------------
206+
##-----------------------------------------------------------------------------
207207
## Attaches a Managed IAM Policy to user(s), role(s), and/or group(s).
208-
##----------------------------------------------------------------------------------
208+
##-----------------------------------------------------------------------------
209209
resource "aws_iam_policy_attachment" "replication" {
210210
name = "s3-bucket-replication-${module.replica_bucket.id}"
211211
roles = [aws_iam_role.replication.name]

0 commit comments

Comments
 (0)