Skip to content

Commit 6a360c1

Browse files
authored
Merge pull request #5 from clouddrove/CD-147
Fix the labels
2 parents 02e5f08 + b4b3ad1 commit 6a360c1

File tree

6 files changed

+14
-11
lines changed

6 files changed

+14
-11
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<hr>
3939

4040

41-
We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
41+
We eat, drink, sleep and most importantly love **DevOps**. We are working towards stratergies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
4242

4343
This module is basically combination of [Terraform open source](https://www.terraform.io/) and includes automatation tests and examples. It also helps to create and improve your infrastructure with minimalistic code instead of maintaining the whole infrastructure code yourself.
4444

@@ -72,7 +72,7 @@ This module has a few dependencies:
7272
Here is an example of how you can use this module in your inventory structure:
7373
```hcl
7474
module "ec2" {
75-
source = "git::https://github.com/clouddrove/terraform-aws-ec2.git?ref=tags/0.12.4"
75+
source = "git::https://github.com/clouddrove/terraform-aws-ec2.git?ref=tags/0.12.5"
7676
name = "ec2-instance"
7777
application = "clouddrove"
7878
environment = "test"
@@ -94,7 +94,6 @@ Here is an example of how you can use this module in your inventory structure:
9494
ebs_volume_enabled = true
9595
ebs_volume_type = "gp2"
9696
ebs_volume_size = 30
97-
user_data = "./_bin/user_data.sh"
9897
instance_tags = { "snapshot" = true }
9998
dns_zone_id = "Z1XJD7SSBKXLC1"
10099
hostname = "ec2"
@@ -145,6 +144,7 @@ Here is an example of how you can use this module in your inventory structure:
145144
| ipv6_addresses | List of IPv6 addresses from the range of the subnet to associate with the primary network interface. | list | `<list>` | no |
146145
| key_name | The key name to use for the instance. | string | `` | no |
147146
| label_order | Label order, e.g. `name`,`application`. | list | `<list>` | no |
147+
| managedby | ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'. | string | `anmol@clouddrove.com` | no |
148148
| monitoring | If true, the launched EC2 instance will have detailed monitoring enabled. (Available since v0.6.0). | bool | `false` | no |
149149
| name | Name (e.g. `app` or `cluster`). | string | `` | no |
150150
| network_interface | Customize network interfaces to be attached at instance boot time. | list(map(string)) | `<list>` | no |

README.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ usage : |-
3636
Here is an example of how you can use this module in your inventory structure:
3737
```hcl
3838
module "ec2" {
39-
source = "git::https://github.com/clouddrove/terraform-aws-ec2.git?ref=tags/0.12.4"
39+
source = "git::https://github.com/clouddrove/terraform-aws-ec2.git?ref=tags/0.12.5"
4040
name = "ec2-instance"
4141
application = "clouddrove"
4242
environment = "test"
@@ -58,7 +58,6 @@ usage : |-
5858
ebs_volume_enabled = true
5959
ebs_volume_type = "gp2"
6060
ebs_volume_size = 30
61-
user_data = "./_bin/user_data.sh"
6261
instance_tags = { "snapshot" = true }
6362
dns_zone_id = "Z1XJD7SSBKXLC1"
6463
hostname = "ec2"

_example/_bin/user_data.sh

Lines changed: 0 additions & 2 deletions
This file was deleted.

_example/example.tf

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ provider "aws" {
22
region = "eu-west-1"
33
}
44

5-
6-
75
module "vpc" {
86
source = "git::https://github.com/clouddrove/terraform-aws-vpc.git?ref=tags/0.12.4"
97

@@ -122,7 +120,6 @@ module "ec2" {
122120
ebs_volume_type = "gp2"
123121
ebs_volume_size = 30
124122

125-
user_data = "./_bin/user_data.sh"
126123
instance_tags = { "snapshot" = true }
127124

128125
dns_zone_id = "Z1XJD7SSBKXLC1"

main.tf

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,17 @@
33
# Copyright @ CloudDrove. All Right Reserved.
44

55
#Module : Label
6-
#Description : This terraform module is designed to generate consistent label names and # tags for resources. You can use terraform-labels to implement a strict # naming convention.
6+
#Description : This terraform module is designed to generate consistent label names and
7+
# tags for resources. You can use terraform-labels to implement a strict
8+
# naming convention.
79
module "labels" {
810
source = "git::https://github.com/clouddrove/terraform-labels.git?ref=tags/0.12.0"
911

1012
name = var.name
1113
application = var.application
1214
environment = var.environment
1315
label_order = var.label_order
16+
managedby = var.managedby
1417
}
1518

1619
locals {

variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ variable "tags" {
4242
description = "Additional tags (e.g. map(`BusinessUnit`,`XYZ`)."
4343
}
4444

45+
variable "managedby" {
46+
type = string
47+
default = "anmol@clouddrove.com"
48+
description = "ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'."
49+
}
50+
4551
# Module : EC2 Module
4652
# Description : Terraform EC2 module variables.
4753
variable "ami" {

0 commit comments

Comments
 (0)