Skip to content

Commit ef4f3aa

Browse files
os-dmergify[bot]
authored andcommitted
MdePkg: MdeLibs.dsc.inc: Apply StackCheckLibNull to All Module Types
Now that the ResetVectors are USER_DEFINED modules, they will not be linked against StackCheckLibNull, which were the only modules causing issues. So, we can now remove the kludge we had before and the requirement for every DSC to include StackCheckLibNull for SEC modules and just apply StackCheckLibNull globally. This also changes every DSC to drop the SEC definition of StackCheckLibNull. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
1 parent fd9e984 commit ef4f3aa

File tree

34 files changed

+10
-118
lines changed

34 files changed

+10
-118
lines changed

ArmPkg/ArmPkg.dsc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,6 @@
9191

9292
OemMiscLib|ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
9393

94-
[LibraryClasses.common.SEC]
95-
# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
96-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
97-
9894
[LibraryClasses.common.PEIM]
9995
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
10096
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf

ArmPlatformPkg/ArmPlatformPkg.dsc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@
8686
MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
8787
PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
8888

89-
# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
90-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
91-
9289
[LibraryClasses.AARCH64.MM_STANDALONE]
9390
HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
9491
MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf

ArmVirtPkg/ArmVirt.dsc.inc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,6 @@
182182
DebugLib|ArmVirtPkg/Library/DebugLibFdtPL011Uart/DebugLibFdtPL011UartFlash.inf
183183
!endif
184184

185-
# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
186-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
187-
188185
[LibraryClasses.common.PEI_CORE]
189186
PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
190187
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

CryptoPkg/CryptoPkg.dsc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@
131131
[LibraryClasses.common.SEC]
132132
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf
133133
TlsLib|CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
134-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
135-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
136134

137135
[LibraryClasses.common.PEIM]
138136
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf

DynamicTablesPkg/DynamicTablesPkg.dsc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@
3434
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
3535
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
3636

37-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
38-
[LibraryClasses.common.SEC]
39-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
40-
4137
[LibraryClasses.ARM, LibraryClasses.AARCH64]
4238
PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
4339

EmbeddedPkg/EmbeddedPkg.dsc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@
122122

123123
[LibraryClasses.common.SEC]
124124
ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
125-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
126-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
127125

128126
[LibraryClasses.ARM, LibraryClasses.AARCH64]
129127
ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf

EmulatorPkg/EmulatorPkg.dsc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@
151151
PpiListLib|EmulatorPkg/Library/SecPpiListLib/SecPpiListLib.inf
152152
DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
153153
TimerLib|EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.inf
154-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
155-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
156154

157155
[LibraryClasses.common.USER_DEFINED, LibraryClasses.common.BASE]
158156
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf

FatPkg/FatPkg.dsc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@
4949
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
5050
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
5151

52-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
53-
[LibraryClasses.common.SEC]
54-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
55-
5652
[LibraryClasses.common.PEIM]
5753
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
5854
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf

IntelFsp2Pkg/IntelFsp2Pkg.dsc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
FspSecPlatformLib|IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/SecFspSecPlatformLibNull.inf
4747
FspMultiPhaseLib|IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
4848

49-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
50-
[LibraryClasses.common.SEC]
51-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
52-
5349
[LibraryClasses.common.PEIM, LibraryClasses.common.SEC]
5450
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
5551
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf

IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@
5757

5858
Tpm2CommandLib|SecurityPkg/Library/Tpm2CommandLib/Tpm2CommandLib.inf
5959

60-
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
61-
[LibraryClasses.common.SEC]
62-
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
63-
6460
[LibraryClasses.common.PEIM,LibraryClasses.common.PEI_CORE]
6561
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
6662
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf

0 commit comments

Comments
 (0)