WASM ABI: insert -> datastore_insert_bsatn & impl new semantics (#1639)

Author: Centril

crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PrivateTable.verified.cs

@@ -176,7 +176,9 @@ public override Scope.Extensions ToExtensions()
             );
         }
 
-        var hasAutoIncFields = Members.Any(f => f.Attrs.HasFlag(ColumnAttrs.AutoInc));
+        var autoIncFields = Members
+            .Where(f => f.Attrs.HasFlag(ColumnAttrs.AutoInc))
+            .Select(f => f.Name);
 
         var iTable = $"SpacetimeDB.Internal.ITable<{ShortName}>";
 
@@ -186,7 +188,19 @@ public override Scope.Extensions ToExtensions()
 
         extensions.Contents.Append(
             $$"""
-            static bool {{iTable}}.HasAutoIncFields => {{hasAutoIncFields.ToString().ToLower()}};
+            public void ReadGenFields(System.IO.BinaryReader reader) {
+                {{string.Join(
+                    "\n",
+                    autoIncFields.Select(name =>
+                        $$"""
+                        if ({{name}} == default)
+                        {
+                            {{name}} = BSATN.{{name}}.Read(reader);
+                        }
+                        """
+                    )
+                )}}
+            }
 
             static SpacetimeDB.Internal.Module.TableDesc {{iTable}}.MakeTableDesc(SpacetimeDB.BSATN.ITypeRegistrar registrar) => new (
                 new (

crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs

@@ -27,6 +27,11 @@ public class UniqueAlreadyExistsException : StdbException
     public override string Message => "Value with given unique identifier already exists";
 }
 
+public class ScheduleAtDelayTooLongException : StdbException
+{
+    public override string Message => "Specified delay in scheduling row was too long";
+}
+
 public class BufferTooSmallException : StdbException
 {
     public override string Message => "The provided buffer is not large enough to store the data";

crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#Timers.SendMessageTimer.verified.cs

@@ -31,6 +31,7 @@ public enum Errno : short
     NO_SPACE = 9,
     BUFFER_TOO_SMALL = 11,
     UNIQUE_ALREADY_EXISTS = 12,
+    SCHEDULE_AT_DELAY_TOO_LONG = 13,
 }
 
 #pragma warning disable IDE1006 // Naming Styles - Not applicable to FFI stuff.
@@ -78,6 +79,7 @@ public static CheckedStatus ConvertToManaged(Errno status)
                     Errno.NO_SPACE => new NoSpaceException(),
                     Errno.BUFFER_TOO_SMALL => new BufferTooSmallException(),
                     Errno.UNIQUE_ALREADY_EXISTS => new UniqueAlreadyExistsException(),
+                    Errno.SCHEDULE_AT_DELAY_TOO_LONG => new ScheduleAtDelayTooLongException(),
                     _ => new UnknownException(status),
                 };
             }
@@ -145,7 +147,11 @@ out RowIter out_
     );
 
     [LibraryImport(StdbNamespace)]
-    public static partial CheckedStatus _insert(TableId table_id, byte[] row, uint row_len);
+    public static partial CheckedStatus _datastore_insert_bsatn(
+        TableId table_id,
+        Span<byte> row,
+        ref uint row_len
+    );
 
     [LibraryImport(StdbNamespace)]
     public static partial CheckedStatus _delete_by_col_eq(

crates/bindings-csharp/Codegen/Module.cs

@@ -7,9 +7,9 @@ public interface ITable<T> : IStructuralReadWrite
     where T : ITable<T>, new()
 {
     // These are the methods that codegen needs to implement.
+    void ReadGenFields(BinaryReader reader);
     static abstract Module.TableDesc MakeTableDesc(ITypeRegistrar registrar);
     static abstract Filter CreateFilter();
-    static abstract bool HasAutoIncFields { get; }
 
     // These are static helpers that codegen can use.
 
@@ -150,14 +150,15 @@ public static IEnumerable<T> Query(Expression<Func<T, bool>> query) =>
 
     protected static void Insert(T row)
     {
+        // Insert the row.
         var bytes = ToBytes(row);
-        FFI._insert(tableId, bytes, (uint)bytes.Length);
-        if (T.HasAutoIncFields)
-        {
-            using var stream = new MemoryStream(bytes);
-            using var reader = new BinaryReader(stream);
-            row.ReadFields(reader);
-        }
+        var bytes_len = (uint)bytes.Length;
+        FFI._datastore_insert_bsatn(tableId, bytes, ref bytes_len);
+
+        // Write back any generated column values.
+        using var stream = new MemoryStream(bytes, 0, (int)bytes_len);
+        using var reader = new BinaryReader(stream);
+        row.ReadGenFields(reader);
     }
 
     protected readonly ref struct ColEq

crates/bindings-csharp/Runtime/Exceptions.cs

@@ -54,8 +54,8 @@ IMPORT(Status, _iter_by_col_eq,
        (TableId table_id, ColId col_id, const uint8_t* value,
         uint32_t value_len, RowIter* iter),
        (table_id, col_id, value, value_len, iter));
-IMPORT(Status, _insert, (TableId table_id, const uint8_t* row, uint32_t len),
-       (table_id, row, len));
+IMPORT(Status, _datastore_insert_bsatn, (TableId table_id, const uint8_t* row_ptr, size_t* row_len_ptr),
+       (table_id, row_ptr, row_len_ptr));
 IMPORT(Status, _delete_by_col_eq,
        (TableId table_id, ColId col_id, const uint8_t* value,
         uint32_t value_len, uint32_t* num_deleted),

crates/bindings-csharp/Runtime/Internal/FFI.cs

@@ -5,14 +5,14 @@
     <UnmanagedEntryPointsAssembly Include="SpacetimeDB.Runtime" />
     <WasmImport Include="$(SpacetimeNamespace)!_console_log" />
     <WasmImport Include="$(SpacetimeNamespace)!_iter_by_col_eq" />
-    <WasmImport Include="$(SpacetimeNamespace)!_insert" />
     <WasmImport Include="$(SpacetimeNamespace)!_delete_by_col_eq" />
     <WasmImport Include="$(SpacetimeNamespace)!_iter_start_filtered" />
     <WasmImport Include="$(SpacetimeNamespace)!_table_id_from_name" />
     <WasmImport Include="$(SpacetimeNamespace)!_datastore_table_row_count" />
     <WasmImport Include="$(SpacetimeNamespace)!_datastore_table_scan_bsatn" />
     <WasmImport Include="$(SpacetimeNamespace)!_row_iter_bsatn_advance" />
     <WasmImport Include="$(SpacetimeNamespace)!_row_iter_bsatn_close" />
+    <WasmImport Include="$(SpacetimeNamespace)!_datastore_insert_bsatn" />
     <WasmImport Include="$(SpacetimeNamespace)!_datastore_delete_all_by_eq_bsatn" />
     <WasmImport Include="$(SpacetimeNamespace)!_bytes_source_read" />
     <WasmImport Include="$(SpacetimeNamespace)!_bytes_sink_write" />

crates/bindings-csharp/Runtime/Internal/ITable.cs

@@ -759,6 +759,26 @@ fn spacetimedb_tabletype_impl(item: syn::DeriveInput) -> syn::Result<TokenStream
         )
     });
 
+    // Generate `integrate_generated_columns`
+    // which will integrate all generated auto-inc col values into `_row`.
+    let integrate_gen_col = columns
+        .iter()
+        .filter(|col| col.attr.has_autoinc())
+        .map(|col| col.field.ident.unwrap())
+        .map(|field| {
+            quote_spanned!(field.span()=>
+                if spacetimedb::IsSequenceTrigger::is_sequence_trigger(&_row.#field) {
+                    _row.#field = spacetimedb::sats::bsatn::from_reader(_in).unwrap();
+                }
+            )
+        });
+    let integrate_generated_columns = quote_spanned!(item.span() =>
+        fn integrate_generated_columns(_row: &mut Self, mut _generated_cols: &[u8]) {
+            let mut _in = &mut _generated_cols;
+            #(#integrate_gen_col)*
+        }
+    );
+
     let scheduled_constant = match sats_ty.scheduled {
         Some(reducer_name) => quote!(Some(#reducer_name)),
         None => quote!(None),
@@ -774,6 +794,7 @@ fn spacetimedb_tabletype_impl(item: syn::DeriveInput) -> syn::Result<TokenStream
             ];
             const INDEXES: &'static [spacetimedb::IndexDesc<'static>] = &[#(#indexes),*];
             type InsertResult = #insert_result;
+            #integrate_generated_columns
             #table_id_from_name_func
         }
     };