Skip to content

Commit 27af02c

Browse files
Use database identity not owner identity for metrics (#2868)
1 parent da0757b commit 27af02c

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

crates/core/src/subscription/module_subscription_actor.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,8 @@ impl ModuleSubscriptions {
476476
)
477477
};
478478

479-
let subscription_metrics = SubscriptionMetrics::new(&self.owner_identity, &WorkloadType::Unsubscribe);
479+
let database_identity = self.relational_db.database_identity();
480+
let subscription_metrics = SubscriptionMetrics::new(&database_identity, &WorkloadType::Unsubscribe);
480481

481482
// Always lock the db before the subscription lock to avoid deadlocks.
482483
let tx = scopeguard::guard(self.relational_db.begin_tx(Workload::Unsubscribe), |tx| {
@@ -659,7 +660,8 @@ impl ModuleSubscriptions {
659660

660661
let num_queries = request.query_strings.len();
661662

662-
let subscription_metrics = SubscriptionMetrics::new(&self.owner_identity, &WorkloadType::Subscribe);
663+
let database_identity = self.relational_db.database_identity();
664+
let subscription_metrics = SubscriptionMetrics::new(&database_identity, &WorkloadType::Subscribe);
663665

664666
// How many queries make up this subscription?
665667
subscription_metrics.num_queries_subscribed.inc_by(num_queries as _);
@@ -756,7 +758,8 @@ impl ModuleSubscriptions {
756758
_assert: Option<AssertTxFn>,
757759
) -> Result<ExecutionMetrics, DBError> {
758760
let num_queries = subscription.query_strings.len();
759-
let subscription_metrics = SubscriptionMetrics::new(&self.owner_identity, &WorkloadType::Subscribe);
761+
let database_identity = self.relational_db.database_identity();
762+
let subscription_metrics = SubscriptionMetrics::new(&database_identity, &WorkloadType::Subscribe);
760763

761764
// How many queries make up this subscription?
762765
subscription_metrics.num_queries_subscribed.inc_by(num_queries as _);
@@ -850,7 +853,8 @@ impl ModuleSubscriptions {
850853
mut event: ModuleEvent,
851854
tx: MutTx,
852855
) -> Result<Result<(Arc<ModuleEvent>, ExecutionMetrics), WriteConflict>, DBError> {
853-
let subscription_metrics = SubscriptionMetrics::new(&self.owner_identity, &WorkloadType::Update);
856+
let database_identity = self.relational_db.database_identity();
857+
let subscription_metrics = SubscriptionMetrics::new(&database_identity, &WorkloadType::Update);
854858

855859
// Take a read lock on `subscriptions` before committing tx
856860
// else it can result in subscriber receiving duplicate updates.

0 commit comments

Comments
 (0)