Skip to content

Commit 204f2bc

Browse files
committed
Add TODO file; remove tests for encoder, v8a, v8b, and weekday; README tweaks
1 parent 12b6c0f commit 204f2bc

File tree

7 files changed

+19
-596
lines changed

7 files changed

+19
-596
lines changed

TODO.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# To-dos
2+
3+
* Option to display weekdays as Sun=0 or Sun=1 (per Portuguese!)
4+
* Implement options for full date every 5 minutes
5+
* Is it possible to trip the chime *after* determining if we're in night mode or not
6+
* Reenable rotary encoder with libraries with workable licenses
7+
* In display code, consider using `delayMicroseconds()` which, with its tighter resolution, may give better control over fades and dim levels
8+
* in `checkInputs()`, can all this if/else business be defined at load instead of evaluated every sample? OR is it compiled that way? maybe use `#ifdef`
9+
* in `ctrlEvt()`, could we do release/shorthold on mainSel so we can exit without making changes?
10+
11+
See other TODOs throughout code.

encoder_test/encoder_test.ino

Lines changed: 0 additions & 213 deletions
This file was deleted.

sixtube_lm/sixtube_lm.ino

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,13 @@
1-
// Digital clock code for the Arduino Nano in RLB Designs' Universal Nixie Driver Board v5.0
1+
// Digital clock code for the Arduino Nano in RLB Designs' Universal Nixie Driver Board
22
// featuring timekeeping by DS3231 RTC, driving up to six digits multiplexed 3x2 via two SN74141 driver chips
3-
// An alternate sketch by Luke McKenzie (luke@theclockspot.com) - https://github.com/clockspot/arduino-nixie
4-
// based on original sketch by Robin Birtles (rlb-designs.com) and Chris Gerekos
5-
// based on http://arduinix.com/Main/Code/ANX-6Tube-Clock-Crossfade.txt
6-
7-
//TODO: implement options for full date every 5 minutes
8-
//TODO: see other TODOs throughout
9-
//TODO: is it possible to trip the chime *after* determining if we're in night mode or not
10-
//TODO: reenable rotary encoder with libraries with workable licenses
3+
// Sketch by Luke McKenzie (luke@theclockspot.com) - https://github.com/clockspot/arduino-nixie
4+
// Inspired by original sketch by Robin Birtles (rlb-designs.com) and Chris Gerekos
5+
// Display cycling code derived from http://arduinix.com/Main/Code/ANX-6Tube-Clock-Crossfade.txt
116

127
////////// Hardware configuration //////////
138
//Include the config file that matches your hardware setup. If needed, duplicate an existing one.
149

1510
#include "configs/v8c-6tube-relayswitch-pwm-top.h"
16-
// #include "configs/v5-6tube-red.h"
1711

1812

1913
////////// Other includes, global consts, and vars //////////
@@ -31,8 +25,8 @@ These ones are set outside the options menu (defaults defined in initEEPROM()):
3125
3-4 Day count year
3226
5 Day count month
3327
6 Day count date
34-
7 Alt function (if not power switching)
35-
( 7-15 are available )
28+
7 Function preset (done by Alt when not power-switching)
29+
( 8-15 are available )
3630
3731
These ones are set inside the options menu (defaults defined in arrays below).
3832
Some are skipped when they wouldn't apply to a given clock's hardware config, see fnOptScroll(); these ones will also be set at startup to the start= values, see setup(). Otherwise, make sure these ones' defaults work for all configs.
@@ -298,7 +292,7 @@ void ctrlEvt(byte ctrl, byte evt){
298292
startSet(timerInitial/60,0,1080,1); break;
299293
case fnIsDayCount: //set year like date, but from eeprom like startOpt
300294
startSet(readEEPROM(3,true),2000,9999,1); break;
301-
case fnIsTemp: //is this where we do the calibration? TODO
295+
case fnIsTemp: //could do calibration here if so inclined
302296
case fnIsTubeTester:
303297
default: break;
304298
}

0 commit comments

Comments
 (0)