How do we sort by distance in FIlament?

[RyanPaiva56]

Hi, thanks thanks for an awesome package! It's been working great except for one issue, which is that I can't sort by distance in Filament. I get an error saying the column doesn't exist, which makes sense because it doesn't. So, filament has a way to do a custom sort instead of just by the column, which looks like this:

TextColumn::make('currentPhysicalAddress.distance_to_address')
                ->label('Miles')
                ->formatStateUsing(function ($state) {
                    return $state ? number_format($state / 1609.34, 2) : null;
                })
                ->sortable(
                    true,
                    function (Builder $query, string $direction) {
                        $point = self::getPointFromRequest();
                        if (!$point) {
                            return $query;
                        }
                        return $query
                            ->orderBy(ST::distanceSphere($point, 'addresses.coordinates'), $direction);
                    }
                ),

This looks like it should work, except I'm getting this error:

stripos(): Argument #1 ($haystack) must be of type string, >Clickbar\Magellan\Database\MagellanExpressions\MagellanNumericExpression given

I feel like this isn't a bug, and that I'm doing something wrong with it. Any advice would be greatly appreciated.

[saibotk]

Sorry, i just tested the orderBy but that does not seem to cause any problems and works on my end.

I never used Filament so i cannot test this atm.
But as far as i can see this is no problem with our code. You might need to reveal more of your stack trace for me to be able to correctly identify where the numeric expression is wrongly passed in.

Remember that ST functions should only be used within query builder functions like select, where or orderby etc.

[studnitz]

Adding to that, if you could provide a query where you use orderByRaw like $query->orderByRaw(DB::raw('ST_Distance_Sphere(...)'); which schould work in the Filament case, that would be a great help!