chore(clippy): make it pedantic (yamafaktory#40)

Author: yamafaktory

Cargo.lock

@@ -15,8 +15,8 @@ version = "1.3.9"
 [dependencies]
 indexmap = { version = "1.9.2", features = ["rayon"] }
 itertools = "0.10.5"
-rayon = "1.6.1"
-thiserror = "1.0.38"
+rayon = "1.7.0"
+thiserror = "1.0.39"
 
 [dev-dependencies]
 criterion = "0.4.0"

Cargo.toml

@@ -1,7 +1,7 @@
 use std::{collections::HashMap, fmt::Debug};
 
 /// Bi-directional hashmap used to store the mapping between the internal
-/// unstable indexes - generated by IndexMap and IndexSet - and the exposed
+/// unstable indexes - generated by `IndexMap` and `IndexSet` - and the exposed
 /// stable indexes.
 pub(crate) struct BiHashMap<Index>
 where
@@ -15,7 +15,7 @@ impl<Index> BiHashMap<Index>
 where
     Index: Copy + Debug + Eq,
 {
-    /// Creates a new BiHashMap with no allocation.
+    /// Creates a new `BiHashMap` with no allocation.
     pub(crate) fn new() -> BiHashMap<Index> {
         Self {
             left: HashMap::<usize, Index>::with_capacity(0),

src/core/bi_hash_map.rs

@@ -42,7 +42,7 @@ where
             .insert_full(HyperedgeKey::new(internal_vertices.clone(), weight));
 
         // Update the vertices so that we keep directly track of the hyperedge.
-        for vertex in internal_vertices.into_iter() {
+        for vertex in internal_vertices {
             let (_, index_set) = self
                 .vertices
                 .get_index_mut(vertex)

src/core/hyperedges/add_hyperedge.rs

@@ -8,27 +8,26 @@ where
     // This private method is infallible since adding the same hyperedge
     // will return the existing index.
     pub(crate) fn add_hyperedge_index(&mut self, internal_index: usize) -> HyperedgeIndex {
-        match self.hyperedges_mapping.left.get(&internal_index) {
-            Some(hyperedge_index) => *hyperedge_index,
-            None => {
-                let hyperedge_index = HyperedgeIndex(self.hyperedges_count);
+        if let Some(hyperedge_index) = self.hyperedges_mapping.left.get(&internal_index) {
+            *hyperedge_index
+        } else {
+            let hyperedge_index = HyperedgeIndex(self.hyperedges_count);
 
-                if self
-                    .hyperedges_mapping
-                    .left
-                    .insert(internal_index, hyperedge_index)
-                    .is_none()
-                {
-                    // Update the counter only for the first insertion.
-                    self.hyperedges_count += 1;
-                }
+            if self
+                .hyperedges_mapping
+                .left
+                .insert(internal_index, hyperedge_index)
+                .is_none()
+            {
+                // Update the counter only for the first insertion.
+                self.hyperedges_count += 1;
+            }
 
-                self.hyperedges_mapping
-                    .right
-                    .insert(hyperedge_index, internal_index);
+            self.hyperedges_mapping
+                .right
+                .insert(hyperedge_index, internal_index);
 
-                hyperedge_index
-            }
+            hyperedge_index
         }
     }
 }

src/core/hyperedges/add_hyperedge_index.rs

@@ -52,7 +52,7 @@ where
                     .par_iter()
                     .any(|&current_index| current_index == index)
                 {
-                    acc.push(index.to_owned())
+                    acc.push(index);
                 }
 
                 acc
@@ -73,7 +73,7 @@ where
         let mut all_hyperedges: Vec<HyperedgeIndex> = vec![];
 
         // Iterate over all the deduped vertices.
-        for &vertex in deduped_vertices.iter() {
+        for &vertex in &deduped_vertices {
             // Safely get the hyperedges of the current vertex.
             let mut vertex_hyperedges = self.get_vertex_hyperedges(vertex)?;
 

src/core/hyperedges/contract_hyperedge_vertices.rs

@@ -19,6 +19,6 @@ where
             HypergraphError::InternalHyperedgeIndexNotFound(internal_index),
         )?;
 
-        self.get_vertices(vertices.to_owned())
+        self.get_vertices(vertices)
     }
 }

src/core/hyperedges/get_hyperedge_vertices.rs

@@ -1,5 +1,3 @@
-use std::ops::Deref;
-
 use crate::{errors::HypergraphError, HyperedgeIndex, HyperedgeTrait, Hypergraph, VertexTrait};
 
 impl<V, HE> Hypergraph<V, HE>
@@ -19,6 +17,6 @@ where
             .get_index(internal_index)
             .ok_or(HypergraphError::InternalVertexIndexNotFound(internal_index))?;
 
-        Ok(hyperedge_key.deref())
+        Ok(&**hyperedge_key)
     }
 }

src/core/hyperedges/get_hyperedge_weight.rs

@@ -10,7 +10,7 @@ where
     // Private method to get a vector of HyperedgeIndex from a vector of internal indexes.
     pub(crate) fn get_hyperedges(
         &self,
-        hyperedges: Vec<usize>,
+        hyperedges: &[usize],
     ) -> Result<Vec<HyperedgeIndex>, HypergraphError<V, HE>> {
         hyperedges
             .par_iter()

src/core/hyperedges/get_hyperedges.rs

@@ -16,7 +16,7 @@ where
         from: VertexIndex,
         to: VertexIndex,
     ) -> Result<Vec<HyperedgeIndex>, HypergraphError<V, HE>> {
-        let results = self.get_connections(Connection::InAndOut(from, to))?;
+        let results = self.get_connections(&Connection::InAndOut(from, to))?;
 
         Ok(results
             .into_par_iter()