Skip to content

Commit 724a3ce

Browse files
authored
Merge pull request #1003 from qtomlinson/qt/fix_search
Include component type in search pattern for browse
2 parents 6d64263 + 2b2321a commit 724a3ce

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

src/components/Navigation/Pages/PageBrowse/PageBrowse.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,12 @@ class PageBrowse extends SystemManagedList {
7373

7474
onSearch = value => {
7575
this.setState({ searchTerm: value })
76-
const valueToSearch = this.state.selectedProvider.value + '/' + value
77-
this.props.dispatch(uiBrowseUpdateFilterList(this.props.token, valueToSearch))
76+
const searchPattern = this._buildSearchPattern(this.state.selectedProvider, value)
77+
this.props.dispatch(uiBrowseUpdateFilterList(this.props.token, searchPattern))
78+
}
79+
80+
_buildSearchPattern = (provider, value) => {
81+
return provider.type + '/' + provider.value + '/' + value
7882
}
7983

8084
tableTitle() {
@@ -171,8 +175,8 @@ class PageBrowse extends SystemManagedList {
171175
onProviderChange(item) {
172176
this.setState({ selectedProvider: item })
173177
if (this.state.searchTerm) {
174-
const valueToSearch = item.value + '/' + this.state.searchTerm
175-
this.props.dispatch(uiBrowseUpdateFilterList(this.props.token, valueToSearch))
178+
const searchPattern = this._buildSearchPattern(item, this.state.searchTerm)
179+
this.props.dispatch(uiBrowseUpdateFilterList(this.props.token, searchPattern))
176180
}
177181
}
178182

src/utils/utils.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,16 @@ const types = [
121121
]
122122

123123
const providers = [
124-
{ value: 'npmjs', label: 'NpmJS', image: npmImage },
125-
{ value: 'github', label: 'GitHub', image: gitImage },
126-
{ value: 'mavencentral', label: 'MavenCentral', image: mavenImage },
127-
{ value: 'nuget', label: 'NuGet', image: nugetImage },
128-
{ value: 'pypi', label: 'PyPi', image: pypiImage },
129-
{ value: 'rubygems', label: 'RubyGems', image: gemImage },
130-
{ value: 'cocoapods', label: 'CocoaPods', image: podImage },
131-
{ value: 'cratesio', label: 'Crates.io', image: crateImage },
132-
{ value: 'debian', label: 'Debian', image: debianImage },
133-
{ value: 'packagist', label: 'Packagist', image: composerImage }
124+
{ value: 'npmjs', label: 'NpmJS', image: npmImage, type: 'npm' },
125+
{ value: 'github', label: 'GitHub', image: gitImage, type: 'git' },
126+
{ value: 'mavencentral', label: 'MavenCentral', image: mavenImage, type: 'maven' },
127+
{ value: 'nuget', label: 'NuGet', image: nugetImage, type: 'nuget' },
128+
{ value: 'pypi', label: 'PyPi', image: pypiImage, type: 'pypi' },
129+
{ value: 'rubygems', label: 'RubyGems', image: gemImage, type: 'gem' },
130+
{ value: 'cocoapods', label: 'CocoaPods', image: podImage, type: 'pod' },
131+
{ value: 'cratesio', label: 'Crates.io', image: crateImage, type: 'crate' },
132+
{ value: 'debian', label: 'Debian', image: debianImage, type: 'deb' },
133+
{ value: 'packagist', label: 'Packagist', image: composerImage, type: 'composer' }
134134
]
135135

136136
const multiEditableFields = ['licensed.declared']

0 commit comments

Comments
 (0)