Merge pull request #2346 from ldm0/non_fmt_panic_fix

Fix part of the non_fmt_panic warnings, bump version-sync to 0.9.2

Author: pksunkara

clap_derive/tests/custom-string-parsers.rs

@@ -83,6 +83,7 @@ fn test_parse_hex() {
     let err = HexOpt::try_parse_from(&["test", "-n", "gg"]).unwrap_err();
     assert!(
         err.to_string().contains("invalid digit found in string"),
+        "{}",
         err
     );
 }

clap_derive/tests/non_literal_attributes.rs

@@ -149,6 +149,7 @@ fn test_parse_hex_function_path() {
     let err = HexOpt::try_parse_from(&["test", "-n", "gg"]).unwrap_err();
     assert!(
         err.to_string().contains("invalid digit found in string"),
+        "{}",
         err
     );
 }

clap_generate/Cargo.toml

@@ -39,7 +39,7 @@ clap = { path = "../", version = "3.0.0-beta.2" }
 
 [dev-dependencies]
 pretty_assertions = "0.6"
-version-sync = "0.8"
+version-sync = "0.9"
 
 [features]
 default = []

src/build/app/mod.rs

@@ -2317,11 +2317,11 @@ impl<'help> App<'help> {
                 .collect();
 
             if !args_missing_help.is_empty() {
-                panic!(format!(
+                panic!(
                     "AppSettings::HelpRequired is enabled for the App {}, but at least one of its arguments does not have either `help` or `long_help` set. List of such arguments: {}",
                     self.name,
                     args_missing_help.join(", ")
-                ));
+                );
             }
         }
 

src/parse/validator.rs

@@ -242,7 +242,7 @@ impl<'help, 'app, 'parser> Validator<'help, 'app, 'parser> {
             ));
         }
 
-        panic!(INTERNAL_ERROR_MSG);
+        panic!("{}", INTERNAL_ERROR_MSG);
     }
 
     fn validate_conflicts(&mut self, matcher: &mut ArgMatcher) -> ClapResult<()> {