ETHERPAD: Sometimes crashes when viewing history of big documents

[tiblu]

Overview

Etherpad crashes with error when viewing history of a big document:

06 Nov 2018 16:09:07.362168 <190>1 2018-11-06T14:09:07.203084+00:00 host app web.1 - �[31m[2018-11-06 14:09:07.202] [ERROR] console - �[39mTypeError: Cannot read property 'substring' of undefined
06 Nov 2018 16:09:07.438133 <190>1 2018-11-06T14:09:07.203101+00:00 host app web.1 - at Object.insert (/app/etherpad-lite/src/static/js/Changeset.js:794:44)
06 Nov 2018 16:09:07.438150 <190>1 2018-11-06T14:09:07.203103+00:00 host app web.1 - at Object.exports.mutateTextLines (/app/etherpad-lite/src/static/js/Changeset.js:966:11)
06 Nov 2018 16:09:07.438129 <190>1 2018-11-06T14:09:07.203104+00:00 host app web.1 - at /app/etherpad-lite/src/node/handler/PadMessageHandler.js:1614:19
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203105+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:610:21
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203107+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:249:17
06 Nov 2018 16:09:07.438136 <190>1 2018-11-06T14:09:07.203108+00:00 host app web.1 - at iterate (/app/etherpad-lite/src/node_modules/async/lib/async.js:149:13)
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203110+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:160:25
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203111+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:251:21
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203112+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:615:34
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203114+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:254:17
06 Nov 2018 16:09:07.438133 <190>1 2018-11-06T14:09:07.203115+00:00 host app web.1 - at done (/app/etherpad-lite/src/node_modules/async/lib/async.js:135:19)
06 Nov 2018 16:09:07.438125 <190>1 2018-11-06T14:09:07.203116+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:32:16
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203117+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:251:21
06 Nov 2018 16:09:07.438126 <190>1 2018-11-06T14:09:07.203119+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:575:34
06 Nov 2018 16:09:07.438133 <190>1 2018-11-06T14:09:07.203120+00:00 host app web.1 - at done (/app/etherpad-lite/src/node_modules/async/lib/async.js:135:19)
06 Nov 2018 16:09:07.438125 <190>1 2018-11-06T14:09:07.203121+00:00 host app web.1 - at /app/etherpad-lite/src/node_modules/async/lib/async.js:32:16
06 Nov 2018 16:09:07.438131 <190>1 2018-11-06T14:09:07.203206+00:00 host app web.1 - �[32m[2018-11-06 14:09:07.203] [INFO] console - �[39mgraceful shutdown...
06 Nov 2018 16:09:07.438133 <190>1 2018-11-06T14:09:07.228397+00:00 host app web.1 - �[32m[2018-11-06 14:09:07.228] [INFO] console - �[39mdb sucessfully closed.
06 Nov 2018 16:09:07.98292 <45>1 2018-11-06T14:09:07.297583+00:00 host heroku web.1 - State changed from up to crashed
06 Nov 2018 16:09:07.99188 <45>1 2018-11-06T14:09:07.286531+00:00 host heroku web.1 - Process exited with status 0

MAY be related to #2

TODO

• Why does it crash?
• Fix and PR to EP project - https://github.com/ether/etherpad-lite