Skip to content

Commit 5c27afa

Browse files
Merge pull request #204 from cisco-en-programmability/develop
correctly respond with a binary
2 parents 0e4e052 + 06f9f4f commit 5c27afa

File tree

5 files changed

+91
-72
lines changed

5 files changed

+91
-72
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
## [2.8.10] - 2025-04-01
10+
### Fix
11+
- This release allows the downloads_a_specific_i_cap_packet_capture_file_v1 function to correctly
12+
respond with a binary.
13+
914
## [2.8.9] - 2025-03-13
1015
### Fix
1116
- Correction in the functions set_banner_settings_for_a_site, set_dhcp_settings_for_a_site, set_n_t_p_settings_for_a_site, set_time_zone_for_a_site, set_d_n_s_settings_for_a_site, set_telemetry_settings_for_a_site, set_aaa_settings_for_a_site. #174

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ The following table shows the supported versions.
162162
* - 2.3.7.7
163163
- 2.8.6
164164
* - 2.3.7.9
165-
- 2.8.9
165+
- 2.8.10
166166

167167

168168

dnacentersdk/api/v2_3_7_9/sensors.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def downloads_a_specific_i_cap_packet_capture_file_v1(self,
350350
MalformedRequest: If the request body created is invalid.
351351
ApiError: If the Catalyst Center cloud returns an error.
352352
Documentation Link:
353-
https://developer.cisco.com/docs/dna-center/#!downloads-a-specific-i-c-a-p-packet-capture-file
353+
https://developer.cisco.com/docs/dna-center/#!downloads-a-specific-icap-packet-capture-file
354354
"""
355355
check_type(headers, dict)
356356
check_type(id, str,
@@ -382,9 +382,9 @@ def downloads_a_specific_i_cap_packet_capture_file_v1(self,
382382
endpoint_full_url = apply_path_params(e_url, path_params)
383383
if with_custom_headers:
384384
json_data = self._session.get(endpoint_full_url, params=_params,
385-
headers=_headers)
385+
headers=_headers, stream=True)
386386
else:
387-
json_data = self._session.get(endpoint_full_url, params=_params)
387+
json_data = self._session.get(endpoint_full_url, params=_params, stream=True)
388388

389389
return self._object_factory('bpm_aeb8cee149c55a4a49506e07b6c4385_v2_3_7_9', json_data)
390390

0 commit comments

Comments
 (0)