update files erros and workflows

Author: JosePabloOcampo1212

.github/workflows/sanity_tests.yml

@@ -1,28 +1,26 @@
 ---
 name: CI
-
 on:
   push:
     branches: [main]
+  pull_request:
   schedule:
     - cron: '0 6 * * *'
-  workflow_dispatch:
-  # pull_request:
-
 env:
   NAMESPACE: cisco
   COLLECTION_NAME: catalystcenter
 
 jobs:
   sanity:
     name: Sanity (Ⓐ${{ matrix.ansible }})
+    timeout-minutes: 60
     strategy:
       matrix:
         ansible:
           - stable-2.17
           - stable-2.18
+          - devel
     runs-on: ubuntu-22.04
-
     steps:
       - name: Check out code
         uses: actions/checkout@v3
@@ -43,57 +41,26 @@ jobs:
       - name: Install ansible-base (${{ matrix.ansible }})
         run: pip install https://github.com/ansible/ansible/archive/${{ matrix.ansible }}.tar.gz --disable-pip-version-check
 
-      - name: Run sanity tests
+      - name: Add swap space (2 GB)
         run: |
-          timeout 55m bash -c '
-            while true; do echo "⏳ Sanity running..."; sleep 60; done &
-            ansible-test sanity --docker --docker-privileged -v --color
-          '
-        working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
-
-      - name: Install yamllint
-        run: pip install --user yamllint
-
-      - name: Run yamllint
-        run: yamllint -c .yamllint.yml .
-        working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
-
-  sanity-devel:
-    name: Sanity (Ⓐdevel)
-    runs-on: ubuntu-22.04
-    continue-on-error: true   # No bloquea el resto del pipeline
-
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v3
-        with:
-          path: cisco-en-programmability/dnacenter-ansible
+          sudo fallocate -l 2G /swapfile
+          sudo chmod 600 /swapfile
+          sudo mkswap /swapfile
+          sudo swapon /swapfile
 
-      - name: Create directory
-        run: mkdir -p ./ansible_collections/${{env.NAMESPACE}}
-
-      - name: Move repository
-        run: mv ./cisco-en-programmability/dnacenter-ansible ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
-
-      - name: Set up Python
-        uses: actions/setup-python@v3
-        with:
-          python-version: '3.11'
-
-      - name: Install ansible-base (devel)
-        run: pip install https://github.com/ansible/ansible/archive/devel.tar.gz --disable-pip-version-check
-
-      - name: Run sanity tests (devel)
+      - name: Run sanity tests
         run: |
-          timeout 55m bash -c '
-            while true; do echo "⏳ Devel sanity running..."; sleep 60; done &
-            ansible-test sanity --docker --docker-privileged -v --color
-          '
+          if [ "${{ matrix.ansible }}" = "devel" ]; then
+            echo "⚠ Running reduced tests for devel branch"
+            ansible-test sanity --docker -v --color --test pep8 --test validate-modules
+          else
+            ansible-test sanity --docker -v --color
+          fi
         working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
 
-      - name: Install yamllint
-        run: pip install --user yamllint
-
-      - name: Run yamllint
-        run: yamllint -c .yamllint.yml .
-        working-directory: ./ansible_collections/${{env.NAMESPACE}}/${{env.COLLECTION_NAME}}
+      - name: Dump docker logs (if any)
+        if: failure()
+        run: |
+          echo "🧪 Collecting logs from Docker containers..."
+          docker ps -a
+          docker logs $(docker ps -aq --filter name=ansible-test-controller || true) || true

changelogs/changelog.yaml

@@ -53,3 +53,11 @@ releases:
       minor_changes:
         - The format has been updated to correct errors when uploading a new version to Red Hat.
         - The workflow_manager modules have been updated.
+        - Change host to _host
+        - Change cport to _api_port
+        - Change username to _username
+        - Change password to _password
+        - Change verify to _verify
+        - Change version to _version
+        - Change debug to _debug
+        - This was due to problems with the parameters since there were conflicts

galaxy.yml

@@ -30,7 +30,7 @@ tags:
   - networking
   - sdn
 dependencies:
-  ansible.utils: ">=2.0.0,<5.0"
+  ansible.utils: ">=2.0.0,<7.0"
 repository: https://github.com/cisco-en-programmability/catalystcenter-ansible
 documentation: https://cisco-en-programmability.github.io/catalystcenter-ansible/
 homepage: https://github.com/cisco-en-programmability/catalystcenter-ansible

playbooks/PnP.yml

@@ -7,13 +7,13 @@
     - "{{ CLUSTERFILE }}"
   vars:
     catalystcenter_login: &catalystcenter_login
-      host: "{{ host }}"
-      username: "{{ username }}"
-      password: "{{ password }}"
-      verify: "{{ verify }}"
-      api_port: "{{ api_port }}"
-      version: "{{ version }}"
-      debug: "{{ debug }}"
+      _host: "{{ _host }}"
+      _username: "{{ _username }}"
+      _password: "{{ _password }}"
+      _verify: "{{ _verify }}"
+      _api_port: "{{ _api_port }}"
+      _version: "{{ _version }}"
+      _debug: "{{ _debug }}"
       log_level: DEBUG
   tasks:
     - name: Import devices in bulk

playbooks/PnP_Workflow_Manager_Playbook.yml

@@ -7,13 +7,13 @@
     - "{{ CLUSTERFILE }}"
   vars:
     catalystcenter_login: &catalystcenter_login
-      host: "{{ host }}"
-      username: "{{ username }}"
-      password: "{{ password }}"
-      verify: "{{ verify }}"
-      api_port: "{{ api_port }}"
-      version: "{{ version }}"
-      debug: "{{ debug }}"
+      _host: "{{ _host }}"
+      _username: "{{ _username }}"
+      _password: "{{ _password }}"
+      _verify: "{{ _verify }}"
+      _api_port: "{{ _api_port }}"
+      _version: "{{ _version }}"
+      _debug: "{{ _debug }}"
       log_level: DEBUG
   tasks:
     - name: Import devices in bulk

playbooks/accesspoint_workflow_manager.yml

@@ -8,13 +8,13 @@
   tasks:
     - name: Updating Access Point Site / Configuration details
       cisco.catalystcenter.accesspoint_workflow_manager:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
-        api_port: "{{ api_port }}"
-        version: "{{ version }}"
-        debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _api_port: "{{ _api_port }}"
+        _version: "{{ _version }}"
+        _debug: "{{ _debug }}"
         log: true
         log_level: DEBUG
         config_verify: true

playbooks/app_policy_queuing_profile.yml

@@ -7,13 +7,13 @@
   tasks:
     - name: Create
       cisco.catalystcenter.app_policy_queuing_profile:
-        _host: "{{ host }}"
-        _username: "{{ username }}"
-        _password: "{{ password }}"
-        _verify: "{{ verify }}"
-        _api_port: "{{ api_port }}"
-        _version: "{{ version }}"
-        _debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _api_port: "{{ _api_port }}"
+        _version: "{{ _version }}"
+        _debug: "{{ _debug }}"
         state: present
         id: "a"
         payload:

playbooks/application_set_info.yml

@@ -7,10 +7,10 @@
   tasks:
     - name: Get application sets local-services
       cisco.catalystcenter.application_sets_info:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         name: local-services
         # limit: 3
         # offset: 2

playbooks/application_sets.yml

@@ -7,21 +7,21 @@
   tasks:
     - name: Create an application set
       cisco.catalystcenter.application_sets:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
-        debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _debug: "{{ _debug }}"
         state: present
         payload:
           - name: AppSet1
       register: application_set_result
     - name: Get task info
       cisco.catalystcenter.task_info:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         taskId: "{{ application_set_result.catalystcenter_response.response.taskId }}"
       when:
         - application_set_result.catalystcenter_response is defined

playbooks/applications.yml

@@ -7,11 +7,11 @@
   tasks:
     - name: Create an application
       cisco.catalystcenter.applications:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
-        debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _debug: "{{ _debug }}"
         state: present
         payload:
           - name: itunes-video
@@ -45,10 +45,10 @@
       register: application_result
     - name: Get task info
       cisco.catalystcenter.task_info:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         taskId: "{{ application_result.catalystcenter_response.response.taskId }}"
       when:
         - application_result.catalystcenter_response is defined

playbooks/authentication_import.yml

@@ -7,11 +7,11 @@
   tasks:
     - name: Import certificate file
       cisco.catalystcenter.authentication_import_certificate:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
-        debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _debug: "{{ _debug }}"
         certFilePath: ./files/test.template
         pkFilePath: ./files/test.template
       register: result

playbooks/command_runner_run_command.yml

@@ -7,10 +7,10 @@
   tasks:
     - name: Run command
       cisco.catalystcenter.command_runner_run_command:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         commands:
           - pwd
         deviceUuids:
@@ -21,10 +21,10 @@
         msg: "{{ result }}"
     - name: Get task info
       cisco.catalystcenter.task_info:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         taskId: "{{ result.catalystcenter_response.response.taskId }}"
       when:
         - result.catalystcenter_response is defined

playbooks/configs_backup.yml

@@ -7,13 +7,13 @@
     - "{{ CLUSTERFILE }}"
   vars:
     catalystcenter_login: &catalystcenter_login
-      host: "{{ host }}"
-      username: "{{ username }}"
-      password: "{{ password }}"
-      verify: "{{ verify }}"
-      api_port: "{{ api_port }}"
-      version: "{{ version }}"
-      debug: "{{ debug }}"
+      _host: "{{ _host }}"
+      _username: "{{ _username }}"
+      _password: "{{ _password }}"
+      _verify: "{{ _verify }}"
+      _api_port: "{{ _api_port }}"
+      _version: "{{ _version }}"
+      _debug: "{{ _debug }}"
       log_level: "DEBUG"
   tasks:
     - name: Take backup of a wired 9500 switch

playbooks/configuration_template_version_create.yml

@@ -7,22 +7,22 @@
   tasks:
     - name: Create Configuration Template Version
       cisco.catalystcenter.configuration_template_version_create:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
-        api_port: "{{ api_port }}"
-        version: "{{ version }}"
-        debug: "{{ debug }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
+        _api_port: "{{ _api_port }}"
+        _version: "{{ _version }}"
+        _debug: "{{ _debug }}"
         # comments: string
         templateId: 2121f1d7-d9ea-4eea-8f83-45af2941f5f9
       register: configuration_template_version_create_result
     - name: Get task info
       cisco.catalystcenter.task_info:
-        host: "{{ host }}"
-        username: "{{ username }}"
-        password: "{{ password }}"
-        verify: "{{ verify }}"
+        _host: "{{ _host }}"
+        _username: "{{ _username }}"
+        _password: "{{ _password }}"
+        _verify: "{{ _verify }}"
         taskId: "{{ configuration_template_version_create_result.catalystcenter_response.response.taskId }}"
       when:
         - configuration_template_version_create_result.catalystcenter_response is defined