-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
blockedThis issue or pull request is awaiting the outcome of another issue or pull requestThis issue or pull request is awaiting the outcome of another issue or pull requestimprovementThis issue or pull request will add or improve functionality, maintainability, or ease of useThis issue or pull request will add or improve functionality, maintainability, or ease of usetestThis issue or pull request adds or otherwise modifies test codeThis issue or pull request adds or otherwise modifies test code
Description
💡 Summary
We should uncomment the test logic to use the service.exists
attribute when possible. We should remove the test that is currently in-place as a workaround when doing so.
Motivation and context
Currently a workaround is used to determine whether or not a service exists due to pytest-dev/pytest-testinfra#757. If pytest-dev/pytest-testinfra#754 is merged and a new release containing it is cut we can switch to using this more straightforward check.
Implementation notes
When uncommenting the code we should also remove the existing test as it will be superfluous.
Metadata
Metadata
Assignees
Labels
blockedThis issue or pull request is awaiting the outcome of another issue or pull requestThis issue or pull request is awaiting the outcome of another issue or pull requestimprovementThis issue or pull request will add or improve functionality, maintainability, or ease of useThis issue or pull request will add or improve functionality, maintainability, or ease of usetestThis issue or pull request adds or otherwise modifies test codeThis issue or pull request adds or otherwise modifies test code