Skip to content

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Mar 4, 2025

🗣 Description

This pull request removes support for outdated platforms.

💭 Motivation and context

cisagov/cyhy-runner requires at least Python 3.9 as of cisagov/cyhy-runner#34, and Debian Buster (10) and Ubuntu Focal (20.04) do not offer anything later than Python 3.8. This is currently breaking GitHub Actions for this repository.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Mark Debian Buster and Ubuntu Focal GitHub Actions checks as not required.

cisagov/cyhy-runner requires at least Python 3.9 as of
cisagov/cyhy-runner#34, and Debian Buster (10) and Ubuntu
Focal (20.04) do not offer anything later than Python 3.8.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code labels Mar 4, 2025
@jsf9k jsf9k self-assigned this Mar 4, 2025
@jsf9k jsf9k added this to CyHy System Mar 4, 2025
@jsf9k jsf9k moved this to In Progress in CyHy System Mar 4, 2025
@jsf9k jsf9k marked this pull request as ready for review March 4, 2025 16:21
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners March 4, 2025 16:21
@jsf9k jsf9k requested a review from a team March 4, 2025 16:22
@jsf9k jsf9k enabled auto-merge March 4, 2025 16:22
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell and thanks for all the hiss!

@jsf9k jsf9k merged commit d21aa85 into develop Mar 4, 2025
49 checks passed
@jsf9k jsf9k deleted the bugfix/remove-support-for-ancient-platforms branch March 4, 2025 16:30
@github-project-automation github-project-automation bot moved this from In Progress to Done in CyHy System Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants