#patch: add linting

Author: circa10a

.github/workflows/test.yml

@@ -32,4 +32,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
         with:
-          version: v1.37
+          version: v1.37.1

.golangci.yml

@@ -0,0 +1,42 @@
+linters:
+  enable:
+    - bodyclose
+    - cyclop
+    - deadcode
+    - depguard
+    - dogsled
+    - dupl
+    - errcheck
+    - errorlint
+    - exhaustive
+    - exportloopref
+    - forbidigo
+    - funlen
+    - goconst
+    - gocritic
+    - gocyclo
+    - gofmt
+    - goimports
+    - golint
+    - gomnd
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - interfacer
+    - lll
+    - misspell
+    - nakedret
+    - nolintlint
+    - rowserrcheck
+    - scopelint
+    - staticcheck
+    - structcheck
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - varcheck
+    - whitespace

main.go

@@ -1,16 +1,13 @@
 package main
 
 import (
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"
 
 	"github.com/circa10a/terraform-provider-mcbroken/mcbroken"
 )
 
 func main() {
 	plugin.Serve(&plugin.ServeOpts{
-		ProviderFunc: func() *schema.Provider {
-			return mcbroken.Provider()
-		},
+		ProviderFunc: mcbroken.Provider,
 	})
 }

mcbroken/data_source_cities.go

@@ -40,7 +40,8 @@ func dataSourceCities() *schema.Resource {
 }
 
 func dataSourceCitiesRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
-	client := &http.Client{Timeout: 10 * time.Second}
+	var httpTimeout time.Duration = 10
+	client := &http.Client{Timeout: httpTimeout * time.Second}
 	providerConfig := m.(map[string]interface{})
 	url := providerConfig["url"].(string)
 

mcbroken/data_source_cities_test.go

@@ -8,8 +8,8 @@ import (
 )
 
 func TestAccMcbrokenCities(t *testing.T) {
-	brokenNumberRegex, _ := regexp.Compile(`\d{1,3}(.\d{1,2})?`)
-	cityRegex, _ := regexp.Compile(`[a-zA-Z]+$`)
+	brokenNumberRegex := regexp.MustCompile(`\d{1,3}(.\d{1,2})?`)
+	cityRegex := regexp.MustCompile(`[a-zA-Z]+$`)
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { /* no precheck needed testAccPreCheck(t) */ },
 		ProviderFactories: testAccProviderFactories,

mcbroken/data_source_city.go

@@ -30,7 +30,8 @@ func dataSourceCity() *schema.Resource {
 }
 
 func dataSourceCityRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
-	client := &http.Client{Timeout: 10 * time.Second}
+	var httpTimeout time.Duration = 10
+	client := &http.Client{Timeout: httpTimeout * time.Second}
 	providerConfig := m.(map[string]interface{})
 	url := providerConfig["url"].(string)
 	userChosenCity := d.Get("city").(string)

mcbroken/data_source_city_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func TestAccMcbrokenCity(t *testing.T) {
-	brokenNumberRegex, _ := regexp.Compile(`\d{1,3}(.\d{1,2})?`)
+	brokenNumberRegex := regexp.MustCompile(`\d{1,3}(.\d{1,2})?`)
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { /* no precheck needed testAccPreCheck(t) */ },
 		ProviderFactories: testAccProviderFactories,