This repository was archived by the owner on Apr 13, 2019. It is now read-only.
This repository was archived by the owner on Apr 13, 2019. It is now read-only.
Bot#oper crashes the process when used specific IRCds #256
Description
When Opering on InspIRCd to an o:line (or operclass) with attached snomasks, ModeParser fails with a Cinch::ModeParser::TooManyParametersError exception.
Seems to be caused by the module not expecting usermodes to have parameters at all.
The issue could be fixed here, but i am.. almost completely unsure how to fix this without foobaring other networks.
Trace:
[2018/01/03 18:14:51.724] II Detected IRCd: inspircd
[2018/01/03 18:14:51.725] II Detected network: irchighway
[2018/01/03 18:14:52.075] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/irc.rb:517:in `parse_bot_modes': #<struct Cinch::ModeParser::TooManyParametersError modes="+s", params=["+lLAakKoOtGg"]> (Cinch::Exceptions::InvalidModeString)
[2018/01/03 18:14:52.075] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/irc.rb:453:in `on_mode'
[2018/01/03 18:14:52.075] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/irc.rb:263:in `parse'
[2018/01/03 18:14:52.075] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/irc.rb:151:in `block (2 levels) in start_reading_thread'
[2018/01/03 18:14:52.076] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/helpers.rb:123:in `rescue_exception'
[2018/01/03 18:14:52.076] !! /home/vhost/.rvm/gems/ruby-2.4.1/gems/cinch-2.3.4/lib/cinch/irc.rb:149:in `block in start_reading_thread'