Skip to content

Commit b11d029

Browse files
authored
[BUG] Ensure arrow sizing is correct / 64 byte aligned (#2426)
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Arrow will overreport the size of a buffer if the underlying buffers are shared (apache/arrow-rs#5969). - apache/arrow-rs#5554 Exposes the ability to enforce alignment at write time. This PR enables this option explicitly and upgrades arrow to take advantage of it. We don't change from the default alignment but this is defensive. - See the comments in get_size() for further understanding of this PR (https://github.com/chroma-core/chroma/pull/2426/files#diff-03bcd4f01acfa68c46fcc974d3722fa621056b4e0f908d708a2d15028b0e99b1R410) - Cleans up various error handling and documentation - adding explicit errors and removing panics as needed - New functionality - None ## Test plan *How are these changes tested?* Updated all tests in delta.rs to save, load and check the sizes match - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
1 parent 6ffae91 commit b11d029

File tree

5 files changed

+546
-194
lines changed

5 files changed

+546
-194
lines changed

Cargo.lock

Lines changed: 50 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/worker/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ parking_lot = "0.12.1"
4141
aws-sdk-s3 = "1.5.0"
4242
aws-smithy-types = "1.1.0"
4343
aws-config = { version = "1.1.2", features = ["behavior-version-latest"] }
44-
arrow = "50.0.0"
44+
arrow = "52.0.0"
4545
roaring = "0.10.3"
4646
tantivy = "0.21.1"
4747
tracing = "0.1"
@@ -55,6 +55,7 @@ opentelemetry = { version = "0.19.0", default-features = false, features = [
5555
opentelemetry-otlp = "0.12.0"
5656
shuttle = "0.7.1"
5757
regex = "1.10.5"
58+
flatbuffers = "24.3.25"
5859

5960
[dev-dependencies]
6061
proptest = "1.4.0"

0 commit comments

Comments
 (0)