Update the regex for variable interpolation.

Author: Alexia

classes/tests/critical.php

@@ -48,7 +48,7 @@ public function getTests() {
 	 * @return	boolean	Line matches test.
 	 */
 	public function _variableInterpolation($line) {
-		$regex = "#(?:(?:->|\\$)\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+|::\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+\[.+?\]\(.*?\))#i";
+		$regex = "#(((::|->)\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*)+\\[[^\s]+\\]\()|(->\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*\\[)|(\\$\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*\\[)|(^\s*?global.*?\\$\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]*)#i"; //@LawnGnome's regex from Twitter; modified and extended to support global simple variable change.
 		if (preg_match($regex, $line)) {
 			return true;
 		}

testcases.php

@@ -1,9 +1,9 @@
 <?php
-$$foo['bar']['baz'];	// interpreted as ($$foo)['bar']['baz']
-$foo->$bar['baz'];		// interpreted as ($foo->$bar)['baz']
-$foo->$bar['baz']();	// interpreted as ($foo->$bar)['baz']()
-Foo::$bar['baz']();		// interpreted as (Foo::$bar)['baz']()
-global $$foo->bar;
+$$foo['bar']['baz'];	//Interpreted as ($$foo)['bar']['baz']
+$foo->$bar['baz'];		//Interpreted as ($foo->$bar)['baz']
+$foo->$bar['baz']();	//Interpreted as ($foo->$bar)['baz']()
+Foo::$bar['baz']();		//Interpreted as (Foo::$bar)['baz']()
+global $$foo->bar;		//The global keyword now only accepts simple variables.
 $array["a"] =& $array["b"]; //Array value created by reference.
 list() = "string";
 list() = $a;