(#3811) Centralize pinned-package message logic

Refactor handling of pinned packages by extracting a single helper
GetPinnedMessage and using it upgrade, outdated, and
other flows. Adjust logging and result message order so that:
- a consolidated message is built once and augmented depending on
  IgnorePinned setting.
- Warn and Inconclusive ResultMessages are added consistently.
- RegularOutput logging is preserved.
- Control flow continues only when pinned packages are skipped.
- Allows overridden services to provide their own pinned message.

This reduces duplicated string formatting, clarifies when pinned
packages are skipped vs upgraded.

Author: AdmiringWorm

src/chocolatey/infrastructure.app/services/NugetService.cs

@@ -1388,30 +1388,30 @@ public virtual ConcurrentDictionary<string, PackageResult> Upgrade(ChocolateyCon
 
                     if (isPinned)
                     {
-                        if (!config.UpgradeCommand.IgnorePinned)
-                        {
-                            var logMessage = "{0} is pinned. Skipping pinned package.".FormatWith(packageName);
-                            packageResult.Messages.Add(new ResultMessage(ResultType.Warn, logMessage));
-                            packageResult.Messages.Add(new ResultMessage(ResultType.Inconclusive, logMessage));
-
-                            if (config.RegularOutput)
-                            {
-                                this.Log().Warn(ChocolateyLoggers.Important, logMessage);
-                            }
+                        var logMessage = GetPinnedPackageMessage(config, installedPackage);
 
-                            continue;
+                        if (config.UpgradeCommand.IgnorePinned)
+                        {
+                            logMessage += " Upgrading pinned package anyway as ignore pin is specified.";
+                            config.PinPackage = true;
                         }
                         else
                         {
-                            var logMessage = "{0} is pinned. Upgrading pinned package anyway as ignore pin is specified".FormatWith(packageName);
-                            packageResult.Messages.Add(new ResultMessage(ResultType.Warn, logMessage));
+                            logMessage += " Skipping pinned package.";
+                        }
 
-                            if (config.RegularOutput)
-                            {
-                                this.Log().Warn(ChocolateyLoggers.Important, logMessage);
-                            }
+                        packageResult.Messages.Add(new ResultMessage(ResultType.Warn, logMessage));
 
-                            config.PinPackage = true;
+                        if (config.RegularOutput)
+                        {
+                            this.Log().Warn(ChocolateyLoggers.Important, logMessage);
+                        }
+
+                        if (!config.UpgradeCommand.IgnorePinned)
+                        {
+                            packageResult.Messages.Add(new ResultMessage(ResultType.Inconclusive, logMessage));
+
+                            continue;
                         }
                     }
 
@@ -1940,7 +1940,7 @@ public virtual ConcurrentDictionary<string, PackageResult> GetOutdated(Chocolate
                 // move on quickly
                 if (isPinned && config.OutdatedCommand.IgnorePinned)
                 {
-                    var pinnedLogMessage = "{0} is pinned. Skipping pinned package.".FormatWith(packageName);
+                    var pinnedLogMessage = GetPinnedPackageMessage(config, installedPackage) + " Skipping pinned package.";
                     var pinnedPackageResult = outdatedPackages.GetOrAdd(packageName, new PackageResult(installedPackage.PackageMetadata, pathResolver.GetInstallPath(installedPackage.PackageMetadata.Id)));
                     pinnedPackageResult.Messages.Add(new ResultMessage(ResultType.Debug, pinnedLogMessage));
                     pinnedPackageResult.Messages.Add(new ResultMessage(ResultType.Inconclusive, pinnedLogMessage));
@@ -2668,7 +2668,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Uninstall(ChocolateyC
                 var pkgInfo = _packageInfoService.Get(installedPackage.PackageMetadata);
                 if (pkgInfo != null && pkgInfo.IsPinned)
                 {
-                    var logMessage = "{0} is pinned. Skipping pinned package.".FormatWith(installedPackage.Name);
+                    var logMessage = GetPinnedPackageMessage(config, installedPackage) + " Skipping pinned package.";
                     var pinnedResult = packageResultsToReturn.GetOrAdd(installedPackage.Name, new PackageResult(installedPackage.Name, null, null));
                     pinnedResult.Messages.Add(new ResultMessage(ResultType.Warn, logMessage));
                     pinnedResult.Messages.Add(new ResultMessage(ResultType.Inconclusive, logMessage));
@@ -3145,6 +3145,11 @@ public IEnumerable<PackageResult> GetInstalledPackages(ChocolateyConfiguration c
             return installedPackages;
         }
 
+        protected virtual string GetPinnedPackageMessage(ChocolateyConfiguration config, PackageResult package)
+        {
+            return "{0} is pinned.".FormatWith(package.Identity.Id);
+        }
+
         private IEnumerable<PackageResult> SetLocalPackageNamesIfAllSpecified(ChocolateyConfiguration config, Action customAction)
         {
             var allPackages = GetInstalledPackages(config);