refactor(angular): simplify runtime file writing logic (#146)

chihab · web-flow · commit 534ee43937d4 · 2025-08-02T16:14:45.000+01:00
remove server output dir parameter and related code since it's unused
diff --git a/README.md b/README.md
@@ -316,4 +316,4 @@ export default {
 
 ## License
 
-MIT © [Chihab Otmani](https://twitter.com/chihabotmani)
+MIT © [Chihab Otmani](https://chihab.dev)
diff --git a/examples/nx-workspace/apps/ng-app-cli/angular.json b/examples/nx-workspace/apps/ng-app-cli/angular.json
@@ -56,7 +56,8 @@
                   "maximumError": "4kb"
                 }
               ],
-              "outputHashing": "all"
+              "outputHashing": "all",
+              "sourceMap": true
             },
             "development": {
               "optimization": false,
diff --git a/packages/angular/README.md b/packages/angular/README.md
@@ -600,14 +600,10 @@ If you prefer using import.meta.env.NGX_SOME_VARIABLE instead of import.meta.env
 +"noPropertyAccessFromIndexSignature": false,
 ```
 
-# How It Works
-
-I wrote an article on [InDepth.dev](https://indepth.dev/tutorials/angular/inject-environment-variables) explaining how it works.
-
 # Credits
 
 - [dotenv](https://github.com/motdotla/dotenv)
 
 # License
 
-MIT © [Chihab Otmani](https://twitter.com/chihabotmani)
+MIT © [Chihab Otmani](https://chihab.dev)
diff --git a/packages/angular/src/builders/application/index.ts b/packages/angular/src/builders/application/index.ts
@@ -12,7 +12,6 @@ import { NgxEnvSchema } from "../ngx-env/ngx-env-schema";
 import { getEnvironment } from "../utils/get-environment";
 import { writeRuntimeFile } from "../utils/write-ngx-env-runtime";
 import { getProjectCwd } from "../utils/project";
-import { replaceHtmlVars } from "../utils/replace-html-vars";
 import { indexHtmlTransformer } from "../utils/index-html-transform";
 
 export const executeWithEnv = (
@@ -49,7 +48,6 @@ export const executeWithEnv = (
             );
             writeRuntimeFile(
               join(outputDir, "browser"),
-              options.ssr ? join(outputDir, "server") : null,
               Array.isArray(options.localize) ? options.localize : [],
               raw
             );
diff --git a/packages/angular/src/builders/utils/index-html-transform-legacy.ts b/packages/angular/src/builders/utils/index-html-transform-legacy.ts
@@ -53,6 +53,6 @@ export function indexHtmlTransformerLegacy(
     });
   }
   if (runtime) {
-    writeRuntimeFile(browserOutputDir, serverOutputDir, locales, raw);
+    writeRuntimeFile(browserOutputDir, locales, raw);
   }
 }
diff --git a/packages/angular/src/builders/utils/index-html-transform.ts b/packages/angular/src/builders/utils/index-html-transform.ts
@@ -4,14 +4,14 @@ import { replaceHtmlVars } from "./replace-html-vars";
 export function indexHtmlTransformer(
   content: string,
   raw: Dict,
-  serve: boolean,
+  devServer: boolean,
   runtime = false
 ) {
   const html = replaceHtmlVars(content, raw);
   return runtime
     ? html.replace(
         /<head>/,
-        serve
+        devServer
           ? `<head><script>globalThis._NGX_ENV_ = ${JSON.stringify(
               raw
             )}</script>`
diff --git a/packages/angular/src/builders/utils/write-ngx-env-runtime.ts b/packages/angular/src/builders/utils/write-ngx-env-runtime.ts
@@ -3,7 +3,6 @@ import { writeFileSync } from "fs";
 
 export function writeRuntimeFile(
   browserOutputDir: string,
-  serverOutputDir: string | null,
   locales: string[] = [],
   raw: Dict
 ) {
@@ -17,22 +16,6 @@ export function writeRuntimeFile(
       );
       try {
         writeFileSync(`${browserOutputDir}/${locale}/ngx-env.js`, runtimeStmt);
-        if (serverOutputDir) {
-          try {
-            console.log(
-              `📦 Writing ngx-env.js to ${serverOutputDir}/${locale}/ngx-env.js`
-            );
-            writeFileSync(
-              `${serverOutputDir}/${locale}/ngx-env.js`,
-              runtimeStmt
-            );
-          } catch (e) {
-            console.log(
-              `❌ Failed to create ngx-env.js at ${serverOutputDir}/ngx-env.js ❌`
-            );
-            throw e;
-          }
-        }
       } catch (e) {
         console.log(
           `❌ Failed to create ngx-env.js at ${browserOutputDir}/${locale}/ngx-env.js ❌`
@@ -50,16 +33,5 @@ export function writeRuntimeFile(
       );
       throw e;
     }
-    if (serverOutputDir) {
-      try {
-        console.log(`📦 Writing ngx-env.js to ${serverOutputDir}/ngx-env.js`);
-        writeFileSync(`${serverOutputDir}/ngx-env.js`, runtimeStmt);
-      } catch (e) {
-        console.log(
-          `❌ Failed to create ngx-env.js at ${serverOutputDir}/ngx-env.js ❌`
-        );
-        throw e;
-      }
-    }
   }
 }
diff --git a/packages/cli/README.md b/packages/cli/README.md
@@ -192,4 +192,4 @@ Use [@ngx-env/builder](https://www.npmjs.com/package/@ngx-env/builder)
 
 # License
 
-MIT © [Chihab Otmani](https://twitter.com/chihabotmani)
+MIT © [Chihab Otmani](https://chihab.dev)

Original file line number	Diff line number	Diff line change
`@@ -316,4 +316,4 @@ export default {`
`316`	`316`
`317`	`317`	`## License`
`318`	`318`
`319`		`-MIT © [Chihab Otmani](https://twitter.com/chihabotmani)`
	`319`	`+MIT © [Chihab Otmani](https://chihab.dev)`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@ export function indexHtmlTransformerLegacy(`
`53`	`53`	`});`
`54`	`54`	`}`
`55`	`55`	`if (runtime) {`
`56`		`- writeRuntimeFile(browserOutputDir, serverOutputDir, locales, raw);`
	`56`	`+ writeRuntimeFile(browserOutputDir, locales, raw);`
`57`	`57`	`}`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -192,4 +192,4 @@ Use [@ngx-env/builder](https://www.npmjs.com/package/@ngx-env/builder)`
`192`	`192`
`193`	`193`	`# License`
`194`	`194`
`195`		`-MIT © [Chihab Otmani](https://twitter.com/chihabotmani)`
	`195`	`+MIT © [Chihab Otmani](https://chihab.dev)`