Merge pull request #807 from chhoumann/fix/tp-file-cursor-issue

fix: handle tp.file.cursor() in template choices

Author: chhoumann

src/engine/CaptureChoiceEngine.ts

@@ -285,7 +285,7 @@ export class CaptureChoiceEngine extends QuickAddChoiceEngine {
 		}
 
 		const file: TFile = await this.createFileWithInput(filePath, fileContent);
-		await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
+		await replaceTemplaterTemplatesInCreatedFile(this.app, file);
 
 		const updatedFileContent: string = await this.app.vault.cachedRead(file);
 		const newFileContent: string = await this.formatter.formatContentWithFile(

src/engine/TemplateEngine.ts

@@ -106,8 +106,8 @@ export abstract class TemplateEngine extends QuickAddEngine {
 				formattedTemplateContent
 			);
 
-			// Always force processing of Templater commands for template choices
-			await replaceTemplaterTemplatesInCreatedFile(this.app, createdFile, true);
+			// Process Templater commands for template choices
+			await replaceTemplaterTemplatesInCreatedFile(this.app, createdFile);
 
 			return createdFile;
 		} catch (err) {
@@ -129,8 +129,8 @@ export abstract class TemplateEngine extends QuickAddEngine {
 				await this.formatter.formatFileContent(templateContent);
 			await this.app.vault.modify(file, formattedTemplateContent);
 
-			// Already forcing Templater processing, keep this as-is
-			await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
+			// Process Templater commands
+			await replaceTemplaterTemplatesInCreatedFile(this.app, file);
 
 			return file;
 		} catch (err) {
@@ -158,8 +158,8 @@ export abstract class TemplateEngine extends QuickAddEngine {
 					: `${fileContent}\n${formattedTemplateContent}`;
 			await this.app.vault.modify(file, newFileContent);
 
-			// Already forcing Templater processing, keep this as-is
-			await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
+			// Process Templater commands
+			await replaceTemplaterTemplatesInCreatedFile(this.app, file);
 
 			return file;
 		} catch (err) {

src/utilityObsidian.ts

@@ -22,17 +22,17 @@ export function getTemplater(app: App) {
 export async function replaceTemplaterTemplatesInCreatedFile(
 	app: App,
 	file: TFile,
-	force = false,
 ) {
 	const templater = getTemplater(app);
 
 	if (!templater) return;
 
-	// Process Templater commands in these cases:
-	// 1. force=true (explicitly requested processing, e.g., for Template choices)
-	// 2. Templater's trigger_on_file_creation=false (manual processing required)
-	const shouldProcess = force || 
-		!(templater.settings as Record<string, unknown>)["trigger_on_file_creation"];
+	const settings = templater.settings as Record<string, unknown>;
+	const triggerOnFileCreation = settings?.["trigger_on_file_creation"];
+	
+	// Only process if Templater's trigger_on_file_creation is disabled
+	// If it's enabled, Templater will process the file automatically
+	const shouldProcess = !triggerOnFileCreation;
 
 	if (shouldProcess) {
 		const impl = templater?.templater as {