Merge pull request #788 from chhoumann/fix/issue-787

fix: templater commands not executing correctly with QuickAdd

Author: chhoumann

src/engine/CaptureChoiceEngine.ts

@@ -284,7 +284,7 @@ export class CaptureChoiceEngine extends QuickAddChoiceEngine {
 		}
 
 		const file: TFile = await this.createFileWithInput(filePath, fileContent);
-		await replaceTemplaterTemplatesInCreatedFile(this.app, file);
+		await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
 
 		const updatedFileContent: string = await this.app.vault.cachedRead(file);
 		const newFileContent: string = await this.formatter.formatContentWithFile(

src/engine/TemplateEngine.ts

@@ -106,7 +106,8 @@ export abstract class TemplateEngine extends QuickAddEngine {
 				formattedTemplateContent
 			);
 
-			await replaceTemplaterTemplatesInCreatedFile(this.app, createdFile);
+			// Always force processing of Templater commands for template choices
+			await replaceTemplaterTemplatesInCreatedFile(this.app, createdFile, true);
 
 			return createdFile;
 		} catch (e) {
@@ -132,6 +133,7 @@ export abstract class TemplateEngine extends QuickAddEngine {
 				await this.formatter.formatFileContent(templateContent);
 			await this.app.vault.modify(file, formattedTemplateContent);
 
+			// Already forcing Templater processing, keep this as-is
 			await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
 
 			return file;
@@ -160,6 +162,7 @@ export abstract class TemplateEngine extends QuickAddEngine {
 					: `${fileContent}\n${formattedTemplateContent}`;
 			await this.app.vault.modify(file, newFileContent);
 
+			// Already forcing Templater processing, keep this as-is
 			await replaceTemplaterTemplatesInCreatedFile(this.app, file, true);
 
 			return file;

src/utilityObsidian.ts

@@ -25,14 +25,16 @@ export async function replaceTemplaterTemplatesInCreatedFile(
 	force = false,
 ) {
 	const templater = getTemplater(app);
-
-	if (
-		templater &&
-		(force ||
-			!(templater.settings as Record<string, unknown>)[
-				"trigger_on_file_creation"
-			])
-	) {
+	
+	if (!templater) return;
+	
+	// Process Templater commands in these cases:
+	// 1. force=true (explicitly requested processing, e.g., for Template choices)
+	// 2. Templater's trigger_on_file_creation=false (manual processing required)
+	const shouldProcess = force || 
+		!(templater.settings as Record<string, unknown>)["trigger_on_file_creation"];
+	
+	if (shouldProcess) {
 		const impl = templater?.templater as {
 			overwrite_file_commands?: (file: TFile) => Promise<void>;
 		};