Skip to content

Commit 2cbe9d8

Browse files
Merge pull request #35 from chenmingyong0423/feature/aggregation
aggregation: rename StageBsonBuilder to NewStageBuilder
2 parents da4dc67 + ac47422 commit 2cbe9d8

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

aggregator/aggregator_e2e_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ func TestAggregator_e2e_Aggregation(t *testing.T) {
158158
require.NoError(t, err)
159159
require.Equal(t, int64(2), deleteResult.DeletedCount)
160160
},
161-
pipeline: aggregation.StageBsonBuilder().Sort(bsonx.M("age", -1)).Build(),
161+
pipeline: aggregation.NewStageBuilder().Sort(bsonx.M("age", -1)).Build(),
162162
want: []*TestUser{
163163
{
164164
Name: "chenmingyong", Age: 24,
@@ -189,7 +189,7 @@ func TestAggregator_e2e_Aggregation(t *testing.T) {
189189
require.NoError(t, err)
190190
require.Equal(t, int64(2), deleteResult.DeletedCount)
191191
},
192-
pipeline: aggregation.StageBsonBuilder().Sort(bsonx.M("age", 1)).Build(),
192+
pipeline: aggregation.NewStageBuilder().Sort(bsonx.M("age", 1)).Build(),
193193
aggregationOptions: []*options.AggregateOptions{
194194
options.Aggregate().SetCollation(&options.Collation{Locale: "en", Strength: 2}),
195195
},
@@ -271,7 +271,7 @@ func TestAggregator_e2e_AggregateWithParse(t *testing.T) {
271271
require.NoError(t, err)
272272
require.Equal(t, int64(2), deleteResult.DeletedCount)
273273
},
274-
pipeline: aggregation.StageBsonBuilder().Set(bsonx.M("is_programmer", true)).Build(),
274+
pipeline: aggregation.NewStageBuilder().Set(bsonx.M("is_programmer", true)).Build(),
275275
result: make([]*User, 0, 4),
276276
want: []*User{
277277
{Id: "1", Name: "cmy", Age: 24, IsProgrammer: true},
@@ -295,7 +295,7 @@ func TestAggregator_e2e_AggregateWithParse(t *testing.T) {
295295
require.NoError(t, err)
296296
require.Equal(t, int64(2), deleteResult.DeletedCount)
297297
},
298-
pipeline: aggregation.StageBsonBuilder().Set(bsonx.M("is_programmer", true)).Sort(bsonx.M("name", 1)).Build(),
298+
pipeline: aggregation.NewStageBuilder().Set(bsonx.M("is_programmer", true)).Sort(bsonx.M("name", 1)).Build(),
299299
result: make([]*User, 0, 4),
300300
want: []*User{
301301
{Id: "1", Name: "cmy", Age: 24, IsProgrammer: true},
@@ -320,7 +320,7 @@ func TestAggregator_e2e_AggregateWithParse(t *testing.T) {
320320
require.NoError(t, err)
321321
require.Equal(t, int64(2), deleteResult.DeletedCount)
322322
},
323-
pipeline: aggregation.StageBsonBuilder().Set(bsonx.M("is_programmer", true)).Sort(bsonx.M("name", 1)).Build(),
323+
pipeline: aggregation.NewStageBuilder().Set(bsonx.M("is_programmer", true)).Sort(bsonx.M("name", 1)).Build(),
324324
result: []string{},
325325
want: []*User{},
326326
aggregationOptions: options.Aggregate().SetCollation(&options.Collation{Locale: "en", Strength: 2}),

builder/aggregation/aggregation_stage_builder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type StageBuilder struct {
2323
pipeline mongo.Pipeline
2424
}
2525

26-
func StageBsonBuilder() *StageBuilder {
26+
func NewStageBuilder() *StageBuilder {
2727
return &StageBuilder{pipeline: make([]bson.D, 0, 4)}
2828
}
2929

builder/aggregation/aggregation_stage_builder_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func TestStageBuilder_AddFields(t *testing.T) {
6464
}
6565
for _, tc := range testCases {
6666
t.Run(tc.name, func(t *testing.T) {
67-
assert.Equal(t, tc.want, StageBsonBuilder().AddFields(tc.value).Build())
67+
assert.Equal(t, tc.want, NewStageBuilder().AddFields(tc.value).Build())
6868
})
6969
}
7070
}
@@ -109,7 +109,7 @@ func TestStageBuilder_Set(t *testing.T) {
109109
}
110110
for _, tc := range testCases {
111111
t.Run(tc.name, func(t *testing.T) {
112-
assert.Equal(t, tc.want, StageBsonBuilder().Set(tc.value).Build())
112+
assert.Equal(t, tc.want, NewStageBuilder().Set(tc.value).Build())
113113
})
114114
}
115115
}
@@ -211,7 +211,7 @@ func TestStageBuilder_Bucket(t *testing.T) {
211211
}
212212
for _, tc := range testCases {
213213
t.Run(tc.name, func(t *testing.T) {
214-
assert.Equal(t, tc.want, StageBsonBuilder().Bucket(tc.groupBy, tc.boundaries, tc.opt).Build())
214+
assert.Equal(t, tc.want, NewStageBuilder().Bucket(tc.groupBy, tc.boundaries, tc.opt).Build())
215215
})
216216
}
217217
}
@@ -286,7 +286,7 @@ func TestStageBuilder_BucketAuto(t *testing.T) {
286286
}
287287
for _, tc := range testCases {
288288
t.Run(tc.name, func(t *testing.T) {
289-
assert.Equal(t, tc.want, StageBsonBuilder().BucketAuto(tc.groupBy, tc.buckets, tc.opt).Build())
289+
assert.Equal(t, tc.want, NewStageBuilder().BucketAuto(tc.groupBy, tc.buckets, tc.opt).Build())
290290
})
291291
}
292292
}
@@ -310,7 +310,7 @@ func TestStageBuilder_Match(t *testing.T) {
310310
}
311311
for _, tc := range testCases {
312312
t.Run(tc.name, func(t *testing.T) {
313-
assert.Equal(t, tc.want, StageBsonBuilder().Match(tc.expression).Build())
313+
assert.Equal(t, tc.want, NewStageBuilder().Match(tc.expression).Build())
314314
})
315315
}
316316
}
@@ -372,7 +372,7 @@ func TestStageBuilder_Group(t *testing.T) {
372372
}
373373
for _, tc := range testCases {
374374
t.Run(tc.name, func(t *testing.T) {
375-
assert.Equal(t, tc.want, StageBsonBuilder().Group(tc.id, tc.accumulators...).Build())
375+
assert.Equal(t, tc.want, NewStageBuilder().Group(tc.id, tc.accumulators...).Build())
376376
})
377377
}
378378
}
@@ -401,7 +401,7 @@ func TestStageBuilder_Sort(t *testing.T) {
401401
}
402402
for _, tc := range testCases {
403403
t.Run(tc.name, func(t *testing.T) {
404-
assert.Equal(t, tc.want, StageBsonBuilder().Sort(tc.value).Build())
404+
assert.Equal(t, tc.want, NewStageBuilder().Sort(tc.value).Build())
405405
})
406406
}
407407
}
@@ -430,17 +430,17 @@ func TestStageBuilder_Project(t *testing.T) {
430430
}
431431
for _, tc := range testCases {
432432
t.Run(tc.name, func(t *testing.T) {
433-
assert.Equal(t, tc.want, StageBsonBuilder().Project(tc.value).Build())
433+
assert.Equal(t, tc.want, NewStageBuilder().Project(tc.value).Build())
434434
})
435435
}
436436
}
437437

438438
func TestStageBuilder_Limit(t *testing.T) {
439-
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$limit", Value: int64(10)}}}, StageBsonBuilder().Limit(10).Build())
439+
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$limit", Value: int64(10)}}}, NewStageBuilder().Limit(10).Build())
440440
}
441441

442442
func TestStageBuilder_Skip(t *testing.T) {
443-
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$skip", Value: int64(10)}}}, StageBsonBuilder().Skip(10).Build())
443+
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$skip", Value: int64(10)}}}, NewStageBuilder().Skip(10).Build())
444444
}
445445

446446
func TestStageBuilder_Unwind(t *testing.T) {
@@ -495,7 +495,7 @@ func TestStageBuilder_Unwind(t *testing.T) {
495495
}
496496
for _, tc := range testCases {
497497
t.Run(tc.name, func(t *testing.T) {
498-
assert.Equal(t, tc.want, StageBsonBuilder().Unwind(tc.path, tc.opt).Build())
498+
assert.Equal(t, tc.want, NewStageBuilder().Unwind(tc.path, tc.opt).Build())
499499
})
500500
}
501501
}
@@ -524,7 +524,7 @@ func TestStageBuilder_ReplaceWith(t *testing.T) {
524524
}
525525
for _, tc := range testCases {
526526
t.Run(tc.name, func(t *testing.T) {
527-
assert.Equal(t, tc.want, StageBsonBuilder().ReplaceWith(tc.replacementDocument).Build())
527+
assert.Equal(t, tc.want, NewStageBuilder().ReplaceWith(tc.replacementDocument).Build())
528528
})
529529
}
530530
}
@@ -612,7 +612,7 @@ func TestStageBuilder_Facet(t *testing.T) {
612612
}
613613
for _, tc := range testCases {
614614
t.Run(tc.name, func(t *testing.T) {
615-
assert.Equal(t, tc.want, StageBsonBuilder().Facet(tc.value).Build())
615+
assert.Equal(t, tc.want, NewStageBuilder().Facet(tc.value).Build())
616616
})
617617
}
618618
}
@@ -645,13 +645,13 @@ func TestStageBuilder_SortByCount(t *testing.T) {
645645
}
646646
for _, tc := range testCases {
647647
t.Run(tc.name, func(t *testing.T) {
648-
assert.Equal(t, tc.want, StageBsonBuilder().SortByCount(tc.expression).Build())
648+
assert.Equal(t, tc.want, NewStageBuilder().SortByCount(tc.expression).Build())
649649
})
650650
}
651651
}
652652

653653
func TestStageBuilder_Count(t *testing.T) {
654-
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$count", Value: "passing_scores"}}}, StageBsonBuilder().Count("passing_scores").Build())
654+
assert.Equal(t, mongo.Pipeline{bson.D{bson.E{Key: "$count", Value: "passing_scores"}}}, NewStageBuilder().Count("passing_scores").Build())
655655
}
656656

657657
func TestStageBuilder_Lookup(t *testing.T) {
@@ -723,7 +723,7 @@ func TestStageBuilder_Lookup(t *testing.T) {
723723
}
724724
for _, tc := range testCases {
725725
t.Run(tc.name, func(t *testing.T) {
726-
assert.Equal(t, tc.want, StageBsonBuilder().Lookup(tc.from, tc.as, tc.opt).Build())
726+
assert.Equal(t, tc.want, NewStageBuilder().Lookup(tc.from, tc.as, tc.opt).Build())
727727
})
728728
}
729729
}

0 commit comments

Comments
 (0)