Skip to content

Commit 6e8668e

Browse files
committed
build: increase minimum supported Python version to 3.8
Python 3.7 is not supported on GitHub Actions ubuntu-latest runner: actions/setup-python#962 Python 3.7 has reached EOL more than 1 year ago anyway, so not worth the effort supporting it.
1 parent 7f7c76f commit 6e8668e

File tree

5 files changed

+9
-15
lines changed

5 files changed

+9
-15
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,11 @@ jobs:
223223
- os: macos-latest
224224
python: pypy3.10
225225

226-
# Minimum Supported Python Version = 3.7
226+
# Minimum Supported Python Version = 3.8
227227
# This is the minimum version for which manylinux Python wheels are
228228
# built. Test it with minimum supported Rust version.
229229
- os: ubuntu-latest
230-
python: 3.7
230+
python: 3.8
231231

232232
runs-on: ${{ matrix.os }}
233233
steps:
@@ -277,9 +277,9 @@ jobs:
277277
- os: macos-latest
278278
python: pypy3.10
279279

280-
# Minimum Supported Python Version = 3.7
280+
# Minimum Supported Python Version = 3.8
281281
- os: ubuntu-latest
282-
python: 3.7
282+
python: 3.8
283283

284284
runs-on: ${{ matrix.os }}
285285
steps:

deltachat-rpc-client/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ classifiers = [
1313
"Operating System :: POSIX :: Linux",
1414
"Operating System :: MacOS :: MacOS X",
1515
"Programming Language :: Python :: 3",
16-
"Programming Language :: Python :: 3.7",
1716
"Programming Language :: Python :: 3.8",
1817
"Programming Language :: Python :: 3.9",
1918
"Programming Language :: Python :: 3.10",
@@ -24,6 +23,7 @@ classifiers = [
2423
"Topic :: Communications :: Email"
2524
]
2625
readme = "README.md"
26+
requires-python = ">=3.8"
2727

2828
[tool.setuptools.package-data]
2929
deltachat_rpc_client = [

deltachat-rpc-client/src/deltachat_rpc_client/rpc.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,7 @@ def __exit__(self, _exc_type, _exc, _tb):
131131

132132
def reader_loop(self) -> None:
133133
try:
134-
while True:
135-
line = self.process.stdout.readline()
136-
if not line: # EOF
137-
break
134+
while line := self.process.stdout.readline():
138135
response = json.loads(line)
139136
if "id" in response:
140137
response_id = response["id"]
@@ -150,10 +147,7 @@ def reader_loop(self) -> None:
150147
def writer_loop(self) -> None:
151148
"""Writer loop ensuring only a single thread writes requests."""
152149
try:
153-
while True:
154-
request = self.request_queue.get()
155-
if not request:
156-
break
150+
while request := self.request_queue.get():
157151
data = (json.dumps(request) + "\n").encode()
158152
self.process.stdin.write(data)
159153
self.process.stdin.flush()

python/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ name = "deltachat"
77
version = "1.153.0"
88
description = "Python bindings for the Delta Chat Core library using CFFI against the Rust-implemented libdeltachat"
99
readme = "README.rst"
10-
requires-python = ">=3.7"
10+
requires-python = ">=3.8"
1111
authors = [
1212
{ name = "holger krekel, Floris Bruynooghe, Bjoern Petersen and contributors" },
1313
]

scripts/run_all.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ unset CHATMAIL_DOMAIN
3131

3232
# Try to build wheels for a range of interpreters, but don't fail if they are not available.
3333
# E.g. musllinux_1_1 does not have PyPy interpreters as of 2022-07-10
34-
tox --workdir "$TOXWORKDIR" -e py37,py38,py39,py310,py311,py312,py313,pypy37,pypy38,pypy39,pypy310 --skip-missing-interpreters true
34+
tox --workdir "$TOXWORKDIR" -e py38,py39,py310,py311,py312,py313,pypy38,pypy39,pypy310 --skip-missing-interpreters true
3535

3636
auditwheel repair "$TOXWORKDIR"/wheelhouse/deltachat* -w "$TOXWORKDIR/wheelhouse"

0 commit comments

Comments
 (0)