set WebrtcRoom for calls

Author: r10s

deltachat-ffi/deltachat.h

@@ -1244,6 +1244,8 @@ uint32_t        dc_init_webxdc_integration    (dc_context_t* context, uint32_t c
  * - callee ends the call using dc_end_call(), caller receives #DC_EVENT_CALL_ENDED
  * - caller ends the call using dc_end_call(), callee receives #DC_EVENT_CALL_ENDED
  *
+ * The call URL is avauilable at dc_msg_get_videochat_url().
+ *
  * Note, that the events are for updating the call screen,
  * possible status messages are added and updated as usual, including the known events.
  * In the UI, the sorted chatlist is used as an overview about calls as well as messages.
@@ -6685,7 +6687,8 @@ void dc_event_unref(dc_event_t* event);
  * Otherwise, ringing should end on #DC_EVENT_CALL_ENDED
  * or #DC_EVENT_INCOMING_CALL_ACCEPTED
  *
- * @param data1 (int) msg_id ID of the info-message referring to the call
+ * @param data1 (int) msg_id ID of the info-message referring to the call.
+ *    The call URL is avauilable at dc_msg_get_videochat_url().
  */
 #define DC_EVENT_INCOMING_CALL                            2550
 

src/calls.rs

@@ -5,15 +5,16 @@
 //! So, no database changes are needed at this stage.
 //! When it comes to relay calls over iroh, we may need a dedicated table, and this may change.
 use crate::chat::{send_msg, Chat, ChatId};
+use crate::config::Config;
 use crate::constants::Chattype;
 use crate::context::Context;
 use crate::events::EventType;
 use crate::message::{self, rfc724_mid_exists, Message, MsgId, Viewtype};
 use crate::mimeparser::{MimeMessage, SystemMessage};
 use crate::param::Param;
 use crate::sync::SyncData;
-use crate::tools::time;
-use anyhow::{ensure, Result};
+use crate::tools::{create_id, time};
+use anyhow::{bail, ensure, Result};
 use std::time::Duration;
 use tokio::task;
 use tokio::time::sleep;
@@ -71,12 +72,24 @@ impl Context {
         let chat = Chat::load_from_db(self, chat_id).await?;
         ensure!(chat.typ == Chattype::Single && !chat.is_self_talk());
 
+        let instance = if let Some(instance) = self.get_config(Config::WebrtcInstance).await? {
+            if !instance.is_empty() {
+                instance
+            } else {
+                bail!("webrtc_instance is empty");
+            }
+        } else {
+            bail!("webrtc_instance not set");
+        };
+        let instance = Message::create_webrtc_instance(&instance, &create_id());
+
         let mut call = Message {
             viewtype: Viewtype::Text,
             text: "Calling...".into(),
             ..Default::default()
         };
         call.param.set_cmd(SystemMessage::OutgoingCall);
+        call.param.set(Param::WebrtcRoom, &instance);
         call.id = send_msg(self, chat_id, &mut call).await?;
 
         let wait = RINGING_SECONDS;
@@ -284,6 +297,8 @@ mod tests {
         let bob2 = tcm.bob().await;
         for t in [&alice, &alice2, &bob, &bob2] {
             t.set_config_bool(Config::SyncMsgs, true).await?;
+            t.set_config(Config::WebrtcInstance, Some("https://foo.bar"))
+                .await?;
         }
 
         // Alice creates a chat with Bob and places an outgoing call there.
@@ -295,12 +310,17 @@ mod tests {
         assert_eq!(sent1.sender_msg_id, test_msg_id);
         assert!(alice_call.is_info());
         assert_eq!(alice_call.get_info_type(), SystemMessage::OutgoingCall);
+        let alice_url = alice_call.get_videochat_url().unwrap();
+        assert!(alice_url.starts_with("https://foo.bar/"));
         let info = alice.load_call_by_root_id(alice_call.id).await?;
         assert!(!info.accepted);
 
         let alice2_call = alice2.recv_msg(&sent1).await;
         assert!(alice2_call.is_info());
         assert_eq!(alice2_call.get_info_type(), SystemMessage::OutgoingCall);
+        let alice2_url = alice2_call.get_videochat_url().unwrap();
+        assert!(alice2_url.starts_with("https://foo.bar/"));
+        assert_eq!(alice_url, alice2_url);
         let info = alice2.load_call_by_root_id(alice2_call.id).await?;
         assert!(!info.accepted);
 
@@ -312,6 +332,9 @@ mod tests {
             .await;
         assert!(bob_call.is_info());
         assert_eq!(bob_call.get_info_type(), SystemMessage::IncomingCall);
+        let bob_url = bob_call.get_videochat_url().unwrap();
+        assert!(bob_url.starts_with("https://foo.bar/"));
+        assert_eq!(alice_url, bob_url);
 
         let bob2_call = bob2.recv_msg(&sent1).await;
         assert!(bob2_call.is_info());

src/message.rs

@@ -1087,10 +1087,8 @@ impl Message {
 
     /// Returns videochat URL if the message is a videochat invitation.
     pub fn get_videochat_url(&self) -> Option<String> {
-        if self.viewtype == Viewtype::VideochatInvitation {
-            if let Some(instance) = self.param.get(Param::WebrtcRoom) {
-                return Some(Message::parse_webrtc_instance(instance).1);
-            }
+        if let Some(instance) = self.param.get(Param::WebrtcRoom) {
+            return Some(Message::parse_webrtc_instance(instance).1);
         }
         None
     }

src/mimefactory.rs

@@ -1546,6 +1546,9 @@ impl MimeFactory {
                 "Chat-Content",
                 mail_builder::headers::raw::Raw::new("videochat-invitation").into(),
             ));
+        }
+
+        if msg.param.exists(Param::WebrtcRoom) {
             headers.push((
                 "Chat-Webrtc-Room",
                 mail_builder::headers::raw::Raw::new(

src/mimeparser.rs

@@ -695,16 +695,18 @@ impl MimeMessage {
     }
 
     fn parse_videochat_headers(&mut self) {
-        if let Some(value) = self.get_header(HeaderDef::ChatContent) {
-            if value == "videochat-invitation" {
-                let instance = self
-                    .get_header(HeaderDef::ChatWebrtcRoom)
-                    .map(|s| s.to_string());
-                if let Some(part) = self.parts.first_mut() {
+        let is_videochat_invite =
+            self.get_header(HeaderDef::ChatContent).unwrap_or_default() == "videochat-invitation";
+        let instance = self
+            .get_header(HeaderDef::ChatWebrtcRoom)
+            .map(|s| s.to_string());
+        if let Some(part) = self.parts.first_mut() {
+            //
+            if let Some(instance) = instance {
+                if is_videochat_invite {
                     part.typ = Viewtype::VideochatInvitation;
-                    part.param
-                        .set(Param::WebrtcRoom, instance.unwrap_or_default());
                 }
+                part.param.set(Param::WebrtcRoom, instance);
             }
         }
     }