Skip to content

Commit 6d14894

Browse files
author
Charles Larivier
committed
fix: incorrect import of MISSING in test_resource.py
1 parent 7f84e02 commit 6d14894

File tree

1 file changed

+23
-8
lines changed

1 file changed

+23
-8
lines changed

tests/test_resource.py

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
1-
from unittest import TestCase
2-
from unittest.mock import call, patch
3-
from requests import HTTPError
1+
from unittest.mock import patch
42

53
from exceptions import NotFoundError
6-
from metabase.metabase import Metabase
7-
from metabase.resource import CreateResource, DeleteResource, GetResource, ListResource, Resource, UpdateResource
8-
from missing import MISSING
4+
from requests import HTTPError
95

6+
from metabase.metabase import Metabase
7+
from metabase.missing import MISSING
8+
from metabase.resource import (
9+
CreateResource,
10+
DeleteResource,
11+
GetResource,
12+
ListResource,
13+
Resource,
14+
UpdateResource,
15+
)
1016
from tests.helpers import IntegrationTestCase
1117

1218

@@ -40,6 +46,7 @@ def test_connection(self):
4046
class ListResourceTests(IntegrationTestCase):
4147
def test_list(self):
4248
"""Ensure ListResource.list() returns a list of objects from Metabase, if any."""
49+
4350
class Setting(ListResource):
4451
ENDPOINT = "/api/setting"
4552
PRIMARY_KEY = None
@@ -52,6 +59,7 @@ class Setting(ListResource):
5259
class GetResourceTests(IntegrationTestCase):
5360
def test_get(self):
5461
"""Ensure GetResource.get() returns an instance of an object, by ID, if any."""
62+
5563
class User(GetResource):
5664
ENDPOINT = "/api/user"
5765

@@ -60,6 +68,7 @@ class User(GetResource):
6068

6169
def test_get_404(self):
6270
"""Ensure GetResource.get() raises NotFoundError if the object does not exist."""
71+
6372
class User(GetResource):
6473
ENDPOINT = "/api/user"
6574

@@ -70,17 +79,19 @@ class User(GetResource):
7079
class CreateResourceTests(IntegrationTestCase):
7180
def test_create(self):
7281
"""Ensure CreateResource.create() creates an object in Metabase and returns an instance."""
82+
7383
class Collection(CreateResource, GetResource):
7484
ENDPOINT = "/api/collection"
7585

7686
collection = Collection.create(name="My Collection", color="#123456")
7787
self.assertIsInstance(collection, Collection)
78-
self.assertIsNotNone(Collection.get(collection.id)) # metabase was updated
88+
self.assertIsNotNone(Collection.get(collection.id)) # metabase was updated
7989

8090

8191
class UpdateResourceTests(IntegrationTestCase):
8292
def test_update(self):
8393
"""Ensure UpdateResource.update() updates an existing object in Metabase."""
94+
8495
class Collection(CreateResource, GetResource, UpdateResource):
8596
ENDPOINT = "/api/collection"
8697

@@ -97,6 +108,7 @@ class Collection(CreateResource, GetResource, UpdateResource):
97108

98109
def test_update_missing(self):
99110
"""Ensure UpdateResource.update() ignores arguments equal to MISSING."""
111+
100112
class Collection(UpdateResource):
101113
ENDPOINT = "/api/collection"
102114

@@ -114,12 +126,15 @@ class Collection(UpdateResource):
114126
pass
115127

116128
self.assertTrue(mock.called)
117-
self.assertIsNone(mock.assert_called_with("/api/collection/1", json=expected))
129+
self.assertIsNone(
130+
mock.assert_called_with("/api/collection/1", json=expected)
131+
)
118132

119133

120134
class DeleteResourceTests(IntegrationTestCase):
121135
def test_delete(self):
122136
"""Ensure DeleteResource.delete() deletes an existing object in Metabase."""
137+
123138
class Group(CreateResource, GetResource, DeleteResource):
124139
ENDPOINT = "/api/permissions/group"
125140
PRIMARY_KEY = "id"

0 commit comments

Comments
 (0)