feat(aggregation): add support for aggregation name

Signed-off-by: Charles Lariviere <charles@dribbble.com>

Author: Charles Lariviere

src/metabase/mbql/aggregations.py

@@ -1,23 +1,46 @@
 from typing import List
 
-from metabase.mbql.base import Mbql
+from metabase.mbql.base import Mbql, Option
 
 
 class Aggregation(Mbql):
     function: str
 
+    def __init__(self, id: int, name: str = None, option: Option = None):
+        self.name = name
+        super(Aggregation, self).__init__(id=id, option=option)
+
     def compile(self) -> List:
-        return [self.function, super(Aggregation, self).compile()]
+        compiled = [self.function, super(Aggregation, self).compile()]
+
+        if self.name is not None:
+            compiled = self.compile_name(compiled, self.name)
+
+        return compiled
+
+    @staticmethod
+    def compile_name(compiled, name: str) -> str:
+        return (
+            ["aggregation-options"]
+            + [compiled]
+            + [{"name": name, "display-name": name}]
+        )
 
 
 class Count(Aggregation):
     function = "count"
 
-    def __init__(self, id: int = None):
+    def __init__(self, id: int = None, name: str = None, option: Option = None):
         self.id = id
+        self.name = name
 
     def compile(self) -> List:
-        return [self.function]
+        compiled = [self.function]
+
+        if self.name is not None:
+            compiled = self.compile_name(compiled, self.name)
+
+        return compiled
 
 
 class Sum(Aggregation):

tests/mbql/test_aggregations.py

@@ -16,10 +16,30 @@ class Mock(Aggregation):
         aggregation = Mock(id=2, option={"foo": "bar"})
         self.assertEqual(["mock", ["field", 2, {"foo": "bar"}]], aggregation.compile())
 
+        aggregation = Mock(id=2, name="My Aggregation", option={"foo": "bar"})
+        self.assertEqual(
+            [
+                "aggregation-options",
+                ["mock", ["field", 2, {"foo": "bar"}]],
+                {"name": "My Aggregation", "display-name": "My Aggregation"},
+            ],
+            aggregation.compile(),
+        )
+
     def test_count(self):
         """Ensure Count optionally accepts an id attribute."""
         count = Count()
         self.assertEqual(["count"], count.compile())
 
         count = Count(id=5)
         self.assertEqual(["count"], count.compile())
+
+        count = Count(id=5, name="My Count")
+        self.assertEqual(
+            [
+                "aggregation-options",
+                ["count"],
+                {"name": "My Count", "display-name": "My Count"},
+            ],
+            count.compile(),
+        )