Skip to content

Commit 4a2e55b

Browse files
author
Charles Larivier
committed
feat: add parameters to Metric.update
1 parent 4d75105 commit 4a2e55b

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

metabase/resources/metric.py

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
from datetime import datetime
44
from typing import List
55

6-
from metabase.resource import ListResource, CreateResource, GetResource, UpdateResource, DeleteResource
7-
from missing import MISSING
6+
from metabase.resource import ListResource, CreateResource, GetResource, UpdateResource
7+
from metabase.missing import MISSING
88

99

1010
class Metric(ListResource, CreateResource, GetResource, UpdateResource):
@@ -64,21 +64,18 @@ def update(
6464
show_in_getting_started: bool = MISSING,
6565
**kwargs
6666
) -> None:
67-
params = {
68-
"revision_message": revision_message,
69-
"name": name,
70-
"description": description,
71-
"definition": definition,
72-
"how_is_this_calculated": how_is_this_calculated,
73-
"points_of_interest": points_of_interest,
74-
"caveats": caveats,
75-
"archived": archived,
76-
"show_in_getting_started": show_in_getting_started,
67+
return super(Metric, self).update(
68+
revision_message=revision_message,
69+
name=name,
70+
description=description,
71+
definition=definition,
72+
how_is_this_calculated=how_is_this_calculated,
73+
points_of_interest=points_of_interest,
74+
caveats=caveats,
75+
archived=archived,
76+
show_in_getting_started=show_in_getting_started,
7777
**kwargs
78-
}
79-
params = {k: v for k, v in params.items() if v != MISSING}
80-
81-
return super(Metric, self).update(**params)
78+
)
8279

8380
def archive(self):
8481
return self.update(archived=True, revision_message="Archived by metabase-python.")

0 commit comments

Comments
 (0)