Skip to content

Commit 46fae69

Browse files
[Misc] V0 fallback for --enable-prompt-embeds (vllm-project#17615)
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
1 parent f66f1e0 commit 46fae69

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

vllm/engine/arg_utils.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,6 +1237,12 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:
12371237
recommend_to_remove=False)
12381238
return False
12391239

1240+
# No text embedding inputs so far.
1241+
if self.enable_prompt_embeds:
1242+
_raise_or_fallback(feature_name="--enable-prompt-embeds",
1243+
recommend_to_remove=False)
1244+
return False
1245+
12401246
# Only Fp16 and Bf16 dtypes since we only support FA.
12411247
V1_SUPPORTED_DTYPES = [torch.bfloat16, torch.float16]
12421248
if model_config.dtype not in V1_SUPPORTED_DTYPES:

vllm/inputs/preprocess.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
from typing_extensions import assert_never
88

9-
from vllm import envs
109
from vllm.config import ModelConfig
1110
from vllm.logger import init_logger
1211
from vllm.lora.request import LoRARequest
@@ -306,8 +305,6 @@ def _process_embeds(
306305
if not self.model_config.enable_prompt_embeds:
307306
raise ValueError("You must set `--enable-prompt-embeds` to input "
308307
"`prompt_embeds`.")
309-
if envs.VLLM_USE_V1:
310-
raise ValueError("`prompt_embeds` is only available in V0.")
311308

312309
prompt_embeds = parsed_content["prompt_embeds"]
313310

0 commit comments

Comments
 (0)