Skip to content

Gitlab Client: Parse owner and repository in a url safe way #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gitlab Client: Parse owner and repository in a url safe way #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions perceval/backends/core/gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,8 @@ def merge(self, merge_id):
"""Get the merge full data"""

path = urijoin(self.base_url,
self.RPROJECTS, self.owner + '%2F' + self.repository,
self.RPROJECTS, urllib.parse.quote(
self.owner + '/' + self.repository, safe=''),
self.RMERGES, merge_id)

response = self.fetch(path)
Expand All @@ -578,7 +579,8 @@ def merge_version(self, merge_id, version_id):
"""Get merge version detail"""

path = urijoin(self.base_url,
self.RPROJECTS, self.owner + '%2F' + self.repository,
self.RPROJECTS, urllib.parse.quote(
self.owner + '/' + self.repository, safe=''),
self.RMERGES, merge_id, self.RVERSIONS, version_id)

response = self.fetch(path)
Expand Down Expand Up @@ -663,7 +665,9 @@ def fetch_items(self, path, payload):

page = 0 # current page
last_page = None # last page
url_next = urijoin(self.base_url, self.RPROJECTS, self.owner + '%2F' + self.repository, path)
url_next = urijoin(
self.base_url, self.RPROJECTS, urllib.parse.quote(
self.owner + '/' + self.repository, safe=''), path)

logger.debug("Get GitLab paginated items from " + url_next)

Expand Down Expand Up @@ -735,7 +739,8 @@ def _set_extra_headers(self):
def _init_rate_limit(self):
"""Initialize rate limit information"""

url = urijoin(self.base_url, 'projects', self.owner + '%2F' + self.repository)
url = urijoin(self.base_url, 'projects', urllib.parse.quote(
self.owner + '/' + self.repository, safe=''))
try:
response = super().fetch(url)
self.update_rate_limit(response)
Expand Down