dhcp.leases is not restored

[Neongoshi]

In trying to find a way to sync two PiHoles together, I have found that your tool is not syncing the dhcp.leases file.

Workaround is to copy the file manually, but since your tool makes use of the Teleporter file, I'd rather if it could restore the entirety of the Teleport file.

Thanks!

[chamilad]

I can't remember if my manual testing covered this. Let me try and see if I can reproduce the issue. I fixed some similar issues recently.

Are you able to describe the case a bit more? Is it not restoring on a fresh install or does it (not) happen even on an existing target pihole instance?

[Neongoshi]

The file is populated in my main Pihole, and I can see it populated as well in the Teleport backup file.

On the second Pihole, let's say that I clear the dhcp.leases file.

Once the Teleport file is transferred to the second Pihole and pihole_restore was run, the dhcp.leases file is still empty.

I'm trying to sync as much as possible the data between my main Pihole (which serves as a DHCP server) and the second Pihole so it can takeover in the event of a failure from the main one, including the leases so hopefully the network is disturbed as little as possible.

[chamilad]

Thanks! Yes, I have left out dhcp.leases file, but I don't remember why. I'm no longer using my pihole as the DHCP server, but let me try and add this.

edit: I remember why. It's because the Teleporter UI doesn't support this itself. But I think we could still do this as an "extra" feature because I can understand the need to have two in sync with the leases. I also wonder why pihole is adding this file to the archive if they are not restoring it from the web UI.

edit2: At a glance, it looks like dhcp.leases is only used to display the current leases, and doesn't seem to have any impact on actual leasing outside of dnsmasq.d/04-pihole-static-dhcp.conf.