Skip to content

Commit ed73b0c

Browse files
committed
Merge branch '2.8' into 3.1
* 2.8: Write an exception message in a one heading line [Finder] Refine phpdoc about argument for NumberComparator Fix unresolved parameters from default bundle configs in debug:config [github] Tweak PR template
2 parents e55f79b + c9d08b6 commit ed73b0c

File tree

5 files changed

+16
-10
lines changed

5 files changed

+16
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
| Q | A
22
| ------------- | ---
3-
| Branch? | "master" for new features / 2.7, 2.8 or 3.1 for fixes
3+
| Branch? | master / 2.7, 2.8, 3.1 or 3.2 <!--see comment below-->
44
| Bug fix? | yes/no
55
| New feature? | yes/no
66
| BC breaks? | yes/no
77
| Deprecations? | yes/no
88
| Tests pass? | yes/no
9-
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any
9+
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
1010
| License | MIT
11-
| Doc PR | reference to the documentation PR, if any
11+
| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->
12+
13+
<!--
14+
- Bug fixes must be submitted against the lowest branch where they apply
15+
(lowest branches are regularly merged to upper ones so they get the fixes too).
16+
- Features and deprecations must be submitted against the master branch.
17+
- Please fill in this template according to the PR you're about to submit.
18+
- Replace this comment by a description of what your PR is solving.
19+
-->

src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
8383
$io->title(sprintf('Current configuration for "%s"', $name));
8484
}
8585

86-
$io->writeln(Yaml::dump(array($extension->getAlias() => $config), 10));
86+
$io->writeln(Yaml::dump(array($extension->getAlias() => $container->getParameterBag()->resolveValue($config)), 10));
8787
}
8888

8989
private function compileContainer()

src/Symfony/Bundle/TwigBundle/Resources/views/Exception/exception.html.twig

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
<img alt="" src="data:image/gif;base64,R0lGODlhHAAWAMQQANra2+bl5s3Mzevr6/Pz8+jo6O3t7fHx8c/Oz+Pj49PS093d3djX2NXV1eDf4MrJyvb29gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAEAABAALAAAAAAcABYAQAWWICSOEDE4AamqRuAsT5yu6hA/wNrcfNysjl5PBOAJAAUDDRLoNRKDndAHnN6k058qaH2QuNelqCAYIm45MfGmIJCkAvUIPNB1td/uAyvEz/UqB0VUagQOZTEjgzx+Kk1CEAU8DAdqB4gPCHVjNwhucphKbzefamAFdlaNEGBZd1V3r1t6fE6wqrJ5XS4Ovb69MyQnv8QhADs=" />
1212
</div>
1313

14-
<h1>
15-
{{ exception.message|nl2br|format_file_from_text }}
16-
</h1>
14+
<h1>{{ exception.message|nl2br|format_file_from_text }}</h1>
1715

1816
<div>
1917
<strong>{{ status_code }}</strong> {{ status_text }} - {{ exception.class|abbr_class }}

src/Symfony/Component/Finder/Comparator/NumberComparator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class NumberComparator extends Comparator
3737
/**
3838
* Constructor.
3939
*
40-
* @param string $test A comparison string
40+
* @param string|int $test A comparison string or an integer
4141
*
4242
* @throws \InvalidArgumentException If the test is not understood
4343
*/

src/Symfony/Component/Finder/Finder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function files()
111111
* $finder->depth('> 1') // the Finder will start matching at level 1.
112112
* $finder->depth('< 3') // the Finder will descend at most 3 levels of directories below the starting point.
113113
*
114-
* @param int $level The depth level expression
114+
* @param string|int $level The depth level expression
115115
*
116116
* @return Finder|SplFileInfo[] The current Finder instance
117117
*
@@ -283,7 +283,7 @@ public function notPath($pattern)
283283
* $finder->size('<= 1Ki');
284284
* $finder->size(4);
285285
*
286-
* @param string $size A size range string
286+
* @param string|int $size A size range string or an integer
287287
*
288288
* @return Finder|SplFileInfo[] The current Finder instance
289289
*

0 commit comments

Comments
 (0)