Skip to content

Commit 66f7126

Browse files
minor symfony#21156 No fallback to REQUEST_TIME in TimeDataCollector (iltar)
This PR was merged into the 3.3-dev branch. Discussion ---------- No fallback to REQUEST_TIME in TimeDataCollector | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (?) | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ As of PHP 5.4 the `REQUEST_TIME_FLOAT` is available and the minimum version of PHP is 5.5 in Symfony. I think it's safe to use as I can't find cases where this is _not_ defined. Commits ------- ba00543 No fallback to REQUEST_TIME in TimeDataCollector
2 parents 98c4e50 + ba00543 commit 66f7126

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Symfony/Component/HttpKernel/DataCollector/TimeDataCollector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function collect(Request $request, Response $response, \Exception $except
3939
if (null !== $this->kernel) {
4040
$startTime = $this->kernel->getStartTime();
4141
} else {
42-
$startTime = $request->server->get('REQUEST_TIME_FLOAT', $request->server->get('REQUEST_TIME'));
42+
$startTime = $request->server->get('REQUEST_TIME_FLOAT');
4343
}
4444

4545
$this->data = array(

src/Symfony/Component/HttpKernel/Tests/DataCollector/TimeDataCollectorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testCollect()
2929

3030
$c->collect($request, new Response());
3131

32-
$this->assertEquals(1000, $c->getStartTime());
32+
$this->assertEquals(0, $c->getStartTime());
3333

3434
$request->server->set('REQUEST_TIME_FLOAT', 2);
3535

0 commit comments

Comments
 (0)