bug symfony#21203 [DependencyInjection] moved up ResolveClassPass in the container pass list (fabpot)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DependencyInjection] moved up ResolveClassPass in the container pass list

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | bug from symfony#21133
| License       | MIT
| Doc PR        | n/a

Some compiler passes need access to the service class names. But when using an empty class name (the service id being the class name), the resolution happens too late (during the optimization step). This PR fixes this by moving up the ResolveClassPass earlier in the stack.

Commits
-------

2e5b69f [DependencyInjection] moved up ResolveClassPass in the container pass list

Author: fabpot

src/Symfony/Component/DependencyInjection/Compiler/PassConfig.php

@@ -39,9 +39,14 @@ public function __construct()
     {
         $this->mergePass = new MergeExtensionConfigurationPass();
 
+        $this->beforeOptimizationPasses = array(
+            100 => array(
+                $resolveClassPass = new ResolveClassPass(),
+            ),
+        );
+
         $this->optimizationPasses = array(array(
             new ExtensionCompilerPass(),
-            $resolveClassPass = new ResolveClassPass(),
             new ResolveDefinitionTemplatesPass(),
             new DecoratorServicePass(),
             new ResolveParameterPlaceHoldersPass(),

src/Symfony/Component/DependencyInjection/Tests/Compiler/PassConfigTest.php

@@ -29,6 +29,8 @@ public function testPassOrdering()
         $pass2 = $this->getMockBuilder(CompilerPassInterface::class)->getMock();
         $config->addPass($pass2, PassConfig::TYPE_BEFORE_OPTIMIZATION, 30);
 
-        $this->assertSame(array($pass2, $pass1), $config->getBeforeOptimizationPasses());
+        $passes = $config->getBeforeOptimizationPasses();
+        $this->assertSame($pass2, $passes[1]);
+        $this->assertSame($pass1, $passes[2]);
     }
 }