Skip to content

Commit ea96e2f

Browse files
authored
fix: rules_apple in resources example (#1542)
The resources example started failing after upgrading to `rules_apple` 3.20.0. @luispadron suggestion of increasing the `destination_timeout` seems to be the workaround. Continue investigation started in #1529.
1 parent 3631aa0 commit ea96e2f

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

examples/resources_example/MODULE.bazel

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ bazel_dep(
1717
)
1818
bazel_dep(
1919
name = "rules_apple",
20-
# TODO: FIX ME!
21-
# version = "3.20.1",
22-
version = "3.17.1",
20+
version = "3.20.1",
2321
repo_name = "build_bazel_rules_apple",
2422
)
2523

examples/resources_example/Tests/MyAppTests/BUILD.bazel

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_unit_test")
2+
load(
3+
"@build_bazel_rules_apple//apple/testing/default_runner:ios_xctestrun_runner.bzl",
4+
"ios_xctestrun_runner",
5+
)
26
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")
37

48
swift_library(
@@ -16,9 +20,19 @@ swift_library(
1620
],
1721
)
1822

23+
ios_xctestrun_runner(
24+
name = "ios_xctestrun_ordered_runner",
25+
# Increased the destination_timeout to avoid test failures due to the
26+
# runner not finding output files. This started happening after upgrade to
27+
# rules_apple 3.20.0.
28+
destination_timeout = 360, # 3 minutes
29+
random = False,
30+
visibility = ["//visibility:public"],
31+
)
32+
1933
ios_unit_test(
2034
name = "MyAppTests",
2135
minimum_os_version = "15.0",
22-
runner = "@build_bazel_rules_apple//apple/testing/default_runner:ios_xctestrun_ordered_runner",
36+
runner = ":ios_xctestrun_ordered_runner",
2337
deps = [":MyAppTestsLib"],
2438
)

0 commit comments

Comments
 (0)