feat: improve error messages and code quality across Swift package tooling (#1720)

## Summary

This PR improves error messages and code quality across the Swift
package tooling ecosystem with several focused enhancements:

- **Enhanced error messages**: Better contextual information for
debugging Swift package configuration issues
- **Security improvement**: More secure file permissions for dependency
index files
- **Code quality**: Fix CLI description typo and enable Claude Code
Review workflow
- **CI optimization**: Skip automated dependency update PRs from code
review

## Changes

### 1. Enhanced Error Messages (`swiftpkg/internal/`)
- **Target lookup errors**: Show available target names/labels when
lookups fail
- **Build declaration errors**: Show available declaration names when
not found
- **Duplicate detection**: Show conflicting declaration types for
duplicates
- **Git configuration errors**: Show what was provided vs what's
required

These improvements help developers quickly identify typos and understand
available options when debugging Swift package configuration issues.

### 2. Security Improvement (`tools/swift_deps_index/cmd/create.go`)
Changed file permissions for dependency index files from `0666`
(world-writable) to `0644` (owner-writable, group/others read-only)
following security best practices.

### 3. Code Quality Fixes
- **CLI description**: Fixed typo "dependences" → "dependencies" in
`swift_deps_index` tool
- **CI workflow**: Enabled Claude Code Review workflow and excluded
Renovate PRs to reduce noise

## Test Plan

- [x] All tests pass: `bazel test //...` (327 tests passed)
- [x] Changes are backwards compatible
- [x] Error message improvements verified through existing test coverage
- [x] Security change maintains functionality while improving
permissions

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: 3 people

.github/workflows/claude-code-review.yml

@@ -1,19 +1,19 @@
 name: Claude Code Review
 
-# on:
-#   pull_request:
-#     types: [opened, synchronize]
-#     # Optional: Only run on specific file changes
-#     # paths:
-#     #   - "src/**/*.ts"
-#     #   - "src/**/*.tsx"
-#     #   - "src/**/*.js"
-#     #   - "src/**/*.jsx"
+on:
+  pull_request:
+    types: [opened, synchronize]
+    # Optional: Only run on specific file changes
+    # paths:
+    #   - "src/**/*.ts"
+    #   - "src/**/*.tsx"
+    #   - "src/**/*.js"
+    #   - "src/**/*.jsx"
 
 jobs:
   claude-review:
-    # Skip draft PRs
-    if: github.event.pull_request.draft == false
+    # Skip draft PRs and Renovate PRs
+    if: github.event.pull_request.draft == false && github.event.pull_request.user.login != 'app/cgrindel-self-hosted-renovate'
 
     # Optional: Filter by PR author
     # if: |

swiftpkg/internal/build_decls.bzl

@@ -75,7 +75,11 @@ def _uniq(decls):
     for decl in results:
         name = decl.name
         if sets.contains(names, name):
-            fail("A duplicate decl name was found. name: {}".format(name))
+            existing_decls = [d for d in results if d.name == name]
+            fail("Duplicate declaration name '{}' found. Declaration types: [{}]".format(
+                name,
+                ", ".join([d.kind for d in existing_decls]),
+            ))
         sets.insert(names, name)
 
     return results
@@ -97,7 +101,11 @@ def _get(decls, name, fail_if_not_found = True):
         if decl.name == name:
             return decl
     if fail_if_not_found:
-        fail("Failed to find build declaration. name:", name)
+        available_names = [d.name for d in decls if d.name]
+        fail("Failed to find build declaration '{}'. Available declarations: [{}]".format(
+            name,
+            ", ".join(available_names),
+        ))
     return None
 
 build_decls = struct(

swiftpkg/internal/pkginfo_targets.bzl

@@ -29,7 +29,11 @@ def _get(targets, name, fail_if_not_found = True):
         if target.name == name:
             return target
     if fail_if_not_found:
-        fail("Failed to find target. name:", name)
+        available_names = [t.name for t in targets]
+        fail("Failed to find target '{}'. Available targets: [{}]".format(
+            name,
+            ", ".join(available_names),
+        ))
     return None
 
 def _get_by_label(targets, label, fail_if_not_found = True):
@@ -50,7 +54,11 @@ def _get_by_label(targets, label, fail_if_not_found = True):
         if target.label == label:
             return target
     if fail_if_not_found:
-        fail("Failed to find target. label:", label)
+        available_labels = [t.label for t in targets]
+        fail("Failed to find target with label '{}'. Available target labels: [{}]".format(
+            label,
+            ", ".join(available_labels),
+        ))
     return None
 
 def _srcs(target):

swiftpkg/internal/swift_package.bzl

@@ -16,11 +16,19 @@ load(":repo_rules.bzl", "repo_rules")
 # MARK: - Environment Variables
 
 def _clone_or_update_repo(repository_ctx, directory):
-    if ((not repository_ctx.attr.tag and not repository_ctx.attr.commit and not repository_ctx.attr.branch) or
-        (repository_ctx.attr.tag and repository_ctx.attr.commit) or
-        (repository_ctx.attr.tag and repository_ctx.attr.branch) or
-        (repository_ctx.attr.commit and repository_ctx.attr.branch)):
-        fail("Exactly one of commit, tag, or branch must be provided")
+    # Validate that exactly one of commit, tag, or branch is provided
+    provided = []
+    if repository_ctx.attr.commit:
+        provided.append("commit")
+    if repository_ctx.attr.tag:
+        provided.append("tag")
+    if repository_ctx.attr.branch:
+        provided.append("branch")
+
+    if len(provided) != 1:
+        fail("Exactly one of commit, tag, or branch must be provided. Found: [{}]".format(
+            ", ".join(provided) if provided else "none",
+        ))
 
     git_ = git_repo(repository_ctx, directory)
 

tools/swift_deps_index/cmd/create.go

@@ -10,7 +10,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-const dependencyIndexPerms = 0666
+const dependencyIndexPerms = 0644
 
 var outputPath string
 

tools/swift_deps_index/cmd/root.go

@@ -9,8 +9,8 @@ import (
 // rootCmd represents the base command when called without any subcommands
 var rootCmd = &cobra.Command{
 	Use:   "swift_deps_index",
-	Short: "Manage a Swift dependences index file.",
-	Long:  `Manage a Swift dependences index file.`,
+	Short: "Manage a Swift dependencies index file.",
+	Long:  `Manage a Swift dependencies index file.`,
 }
 
 // Execute adds all child commands to the root command and sets flags appropriately.