shell_command doesn't display items

[miklos-szel]

I have the following shell_commands in HA:

shell_command:
  wiim_preset_1: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:1'
  wiim_preset_2: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:2'
  wiim_preset_3: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:3'
  wiim_preset_4: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:4'
  wiim_preset_5: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:5'
  wiim_preset_6: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:6'
  wiim_preset_7: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:7'
  wiim_preset_8: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:8'
  wiim_preset_9: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:9'
  wiim_prev: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=setPlayerCmd:prev'
  wiim_toggle: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=setPlayerCmd:onepause'
  wiim_next: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=setPlayerCmd:next'
  wiim_volup: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=setPlayerCmd:vol%2b%2b'
  wiim_voldn: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=setPlayerCmd:vol--'
  wiim_office_preset_1: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:1'
  wiim_office_preset_2: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:2'
  wiim_office_preset_3: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:3'
  wiim_office_preset_4: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:4'
  wiim_office_preset_5: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:5'
  wiim_office_preset_6: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:6'
  wiim_office_preset_7: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:7'
  wiim_office_preset_8: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:8'
  wiim_office_preset_9: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:9'
  wiim_office_preset_10: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:10'
  wiim_office_preset_11: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:11'
  wiim_office_preset_12: 'curl -k https://192.168.xxx.xxx/httpapi.asp?command=MCUKeyShortClick:12'

I can see the number of elements listed in the plugin, they work as well, but their name is not displayed.

[cgiesche]

Hi,

thank you for your detailed report!
I was able to reproduce the problem and found out that shell commands seem to be a bit special compared with other service calls.

Service information returned from HA usually contains a name which is used as display text in the dropdown box:

{
  "turn_on": {
    "name": "Turn on",
    "description": "Turn on one or more lights and adjust properties of the light, even when they are turned on already.",
    "fields": []
}

Shell command services seem to only contain an empty string inside the name field

{
  "wiim_preset_1": {
    "name": "",
    "description": "",
    "fields": {},
    "response": {
      "optional": true
    }
  }
}

This can be easily fixed by using the 'technical' service name when the human readable name is empty.

[PoorShawn]

Hi! I'm a beginner and looking to contribute to this project. This issue seems like a good place for me to start. Could I work on it? I will do my best. 😊

[cgiesche]

Of course you can work on it, every help is welcome :)
A good place to start is the PropertyInspector. Do not expect to find clean code or best practices as JavaScript is not my main programming language :D