Issues for process_select body w/o process_result

[btriller]

Documentation [1] for process_result currently states that if it's missing in a process_select body it will AND all select attributes present in that body but that actually not true.
Given following policy:

body common control
{
}

bundle agent __main__
{
  vars:
      "process_result[vsize_and_ppid]"
        string => "vsize.ppid";

      "process_result[vsize_or_ppid]"
        string => "vsize|ppid";

       "process_results" slist => getindices(process_result);

  processes:
      "sshd"
        process_select => without_process_result,
        restart_class  => "sshd_wo_result_not_found";

      "sshd"
        process_select => with_process_result("$(process_result[$(process_results)])"),
        restart_class  => "sshd_w_$(process_results)_result_not_found";

  reports:
      "sshd without process result not found" if => "sshd_wo_result_not_found";
      "sshd without process result found" unless => "sshd_wo_result_not_found";

      "sshd with process result $(process_results) not found"
        if => "sshd_w_$(process_results)_result_not_found";
      "sshd with process result $(process_results) found"
        unless => "sshd_w_$(process_results)_result_not_found";
}

body process_select without_process_result
{
     vsize => "1,1";
     ppid  => "1,1";
}

body process_select with_process_result(result)
{
     vsize          => "1,1";
     ppid           => "1,1";
     process_result => "$(result)";
}

with

% ps -o pid,ppid,vsz,comm,cmd $(pgrep --parent 1 sshd)
    PID    PPID    VSZ COMMAND         CMD
   1548       1  15620 sshd            sshd: /usr/sbin/sshd -D [listener] 0 of 10-100 startups

IMO should not not report sshd without process result found

.cfagent/bin/cf-agent -KIf process_select.cf
   error: process_select body missing its a process_result return value
   error: Process select constraint body promised no result (check body definition)
   error: Promise belongs to bundle 'main' in file '/home/btriller/.cfagent/inputs/process_select.cf' near line 17
R: sshd without process result found
R: sshd with process result vsize_and_ppid not found
R: sshd with process result vsize_or_ppid found
   error: process_select body missing its a process_result return value
   error: Process select constraint body promised no result (check body definition)
   error: Promise belongs to bundle 'main' in file '/home/btriller/.cfagent/inputs/process_select.cf' near line 17
   error: process_select body missing its a process_result return value
   error: Process select constraint body promised no result (check body definition)
   error: Promise belongs to bundle 'main' in file '/home/btriller/.cfagent/inputs/process_select.cf' near line 17

as vsz won't ever be in the range of 1,1.
Also, if process_select body w/o process_result is allowed, above error messages shouldn't be emitted.

Documentation for this was changed on 10dbceb.

[1] https://github.com/cfengine/documentation/blob/87dd84131ef2b8c169d61d1f9a2996a1586f630f/reference/promise-types/processes.markdown?plain=1#L298-L306

[craigcomstock]

@btriller I can reproduce your issue. Looking at the code that builds up the set of attributes to and together I see that the description we have isn't quite accurate as you have discovered. Instead of all specified attributes being ANDed together, we only AND together the attributes which match processes.

I added a debug log in that code for your example and see this is the case:

   info: no process_result, using attributes anded class expression: 'ppid'

It does seem that both the commit you mention and the docs commit (cfengine/documentation@833b243) do not accurately describe the behavior of the code.

I wasn't sure if I agreed with you about the no process_select behavior when there were more than one other attribute but looking at more examples in the docs I agree with you that the code should work as described and not as implemented.

I have logged a ticket for this: https://northerntech.atlassian.net/browse/CFE-4511 feel free to chime in there or continue the conversation here.

[btriller]

@craigcomstock I played around with it [1] and for

body common control
{
}

bundle agent __main__
{
  vars:
      "proc" string => "sshd";
      "ppid" string => "1";

      "vsize" slist => { "1", "inf" };

      "process_result[vsize_and_ppid]"
        string => "vsize.ppid";

      "process_result[vsize_or_ppid]"
        string => "vsize|ppid";

      "process_results" slist => getindices(process_result);

  processes:
      "$(proc)"
        process_select => without_process_result($(ppid), $(vsize)),
        restart_class  => "$(proc)_vsz_$(vsize)_wo_result_not_found";

      "$(proc)"
        process_select => with_process_result("$(process_result[$(process_results)])", $(ppid), $(vsize)),
        restart_class  => "$(proc)_w_$(process_results)_vsz_$(vsize)_result_not_found";

  reports:
      "$(proc) (ppid $(ppid)) (vsz 1,$(vsize)) without process_result not found" if => "$(proc)_vsz_$(vsize)_wo_result_not_found";
      "$(proc) (ppid $(ppid)) (vsz 1,$(vsize)) without process_result found" unless => "$(proc)_vsz_$(vsize)_wo_result_not_found";

      "$(proc) (ppid $(ppid)) (vsz 1,$(vsize)) with process_result $(process_result[$(process_results)]) not found"
        if     => "$(proc)_w_$(process_results)_vsz_$(vsize)_result_not_found";
      "$(proc) (ppid $(ppid)) (vsz 1,$(vsize)) with process_result $(process_result[$(process_results)]) found"
        unless => "$(proc)_w_$(process_results)_vsz_$(vsize)_result_not_found";
}

body process_select without_process_result(ppid, vsize)
{
     vsize => "1,$(vsize)";
     ppid  => "$(ppid),$(ppid)";
}

body process_select with_process_result(result, ppid, vsize)
{
     vsize          => "1,$(vsize)";
     ppid           => "$(ppid),$(ppid)";
     process_result => "$(result)";
}

output looks ok

   error: ppid min 1, max 1
   error: No process_result attribute
   error: Not all process_select attributes matched
   error: No process_result attribute
   error: No process_select attributes
   error: No process_result attribute
   error: No process_select attributes
   error: No process_result attribute
   error: No process_select attributes
   error: No process_result attribute
   error: No process_select attributes
   error: ppid min 1, max 1
   error: vsize min 1, max 999999999
   error: No process_result attribute
   error: Have some process_select attributes 'ppid.vsize'
   error: vsize min 1, max 999999999
   error: No process_result attribute
   error: Not all process_select attributes matched
   error: vsize min 1, max 999999999
   error: No process_result attribute
   error: Not all process_select attributes matched
   error: vsize min 1, max 999999999
   error: No process_result attribute
   error: Not all process_select attributes matched
   error: vsize min 1, max 999999999
   error: No process_result attribute
   error: Not all process_select attributes matched
   error: ppid min 1, max 1
   error: Have process_result attribute 'vsize|ppid'
   error: Have process_result attribute 'vsize|ppid'
   error: Have process_result attribute 'vsize|ppid'
   error: Have process_result attribute 'vsize|ppid'
   error: Have process_result attribute 'vsize|ppid'
   error: ppid min 1, max 1
   error: Have process_result attribute 'vsize.ppid'
   error: Have process_result attribute 'vsize.ppid'
   error: Have process_result attribute 'vsize.ppid'
   error: Have process_result attribute 'vsize.ppid'
   error: Have process_result attribute 'vsize.ppid'
   error: ppid min 1, max 1
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize|ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize|ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize|ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize|ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize|ppid'
   error: ppid min 1, max 1
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize.ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize.ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize.ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize.ppid'
   error: vsize min 1, max 999999999
   error: Have process_result attribute 'vsize.ppid'
R: sshd (ppid 1) (vsz 1,1) without process_result not found
R: sshd (ppid 1) (vsz 1,inf) without process_result found
R: sshd (ppid 1) (vsz 1,1) with process_result vsize.ppid not found
R: sshd (ppid 1) (vsz 1,1) with process_result vsize|ppid found
R: sshd (ppid 1) (vsz 1,inf) with process_result vsize|ppid found
R: sshd (ppid 1) (vsz 1,inf) with process_result vsize.ppid found

As for Jira, I have no access CFE project.

[1] https://github.com/cfengine/core/compare/master...btriller:cfengine-core:process-select-foo?expand=1

[nickanderson]

As for Jira, I have no access CFE project.

Hey @btriller this link should help with getting you access to the CFE project: https://id.atlassian.com/invite/p/jira-software?id=IZf1JPntQSq-xmDaPZ3kZQ

[craigcomstock]

Yes, your changes look like a good start to fixing the issue.
Feel free to submit a pull request and we will review.
Thanks for the contribution!