Skip to content

Commit d8ebd27

Browse files
authored
Merge pull request #5757 from victormlg/metapromisebegin
CFE-2829: Fixed meta promises verbose logging
2 parents f37ee1a + 37bf296 commit d8ebd27

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

cf-agent/cf-agent.c

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ static int NoteBundleCompliance(const Bundle *bundle, int save_pr_kept, int save
162162
static void AllClassesReport(const EvalContext *ctx);
163163
static bool HasAvahiSupport(void);
164164
static int AutomaticBootstrap(GenericAgentConfig *config);
165-
static void BannerStatus(PromiseResult status, const char *type, char *name);
165+
static void BannerStatusEnd(PromiseResult status, const char *type, char *name);
166+
static void BannerStatusBegin(const char *type, char *name);
166167
static PromiseResult DefaultVarPromise(EvalContext *ctx, const Promise *pp);
167168
static void WaitForBackgroundProcesses();
168169

@@ -1852,6 +1853,7 @@ static PromiseResult KeepAgentPromise(EvalContext *ctx, const Promise *pp, ARG_U
18521853
assert(param == NULL);
18531854
assert(pp != NULL);
18541855

1856+
BannerStatusBegin(PromiseGetPromiseType(pp), pp->promiser);
18551857
struct timespec start = BeginMeasure();
18561858
PromiseResult result = PROMISE_RESULT_NOOP;
18571859

@@ -1976,13 +1978,23 @@ static PromiseResult KeepAgentPromise(EvalContext *ctx, const Promise *pp, ARG_U
19761978
result = PROMISE_RESULT_NOOP;
19771979
}
19781980

1979-
BannerStatus(result, PromiseGetPromiseType(pp), pp->promiser);
1981+
BannerStatusEnd(result, PromiseGetPromiseType(pp), pp->promiser);
19801982
EvalContextLogPromiseIterationOutcome(ctx, pp, result);
19811983
return result;
19821984
}
19831985

1986+
static void BannerStatusBegin(const char *type, char *name)
1987+
{
1988+
if (StringEqual(type, "vars") || StringEqual(type, "classes"))
1989+
{
1990+
return;
1991+
}
1992+
Log(LOG_LEVEL_VERBOSE, "P: BEGIN %s promise (%.30s%s)",
1993+
type, name,
1994+
(strlen(name) > 30) ? "..." : "");
1995+
}
19841996

1985-
static void BannerStatus(PromiseResult status, const char *type, char *name)
1997+
static void BannerStatusEnd(PromiseResult status, const char *type, char *name)
19861998
{
19871999
if ((strcmp(type, "vars") == 0) || (strcmp(type, "classes") == 0))
19882000
{

0 commit comments

Comments
 (0)