libpromises/attributes: Fix file_select attributes check

btriller · btriller · commit 426f4fef3b5e · 2025-03-25T15:38:56.000+01:00
* Remove wrong check on min_size, it's initialized with CF_NOINT and
  evaluated to true
* Add check on group
diff --git a/libpromises/attributes.c b/libpromises/attributes.c
@@ -622,7 +622,7 @@ FileSelect GetSelectConstraints(const EvalContext *ctx, const Promise *pp)
     s.issymlinkto = (Rlist *) PromiseGetConstraintAsRval(pp, "issymlinkto", RVAL_TYPE_LIST);
 
     // check if file_result is needed
-    if ((s.owners) || (s.min_size) || (s.exec_regex) || (s.exec_program) || (s.filetypes)
+    if ((s.owners) || (s.groups) || (s.exec_regex) || (s.exec_program) || (s.filetypes)
             || (s.name) || (s.path) || (s.issymlinkto) || (s.perms) || (s.bsdflags))
     {
         entries = true;

Original file line number	Diff line number	Diff line change
`@@ -622,7 +622,7 @@ FileSelect GetSelectConstraints(const EvalContext ctx, const Promise pp)`
`622`	`622`	`s.issymlinkto = (Rlist *) PromiseGetConstraintAsRval(pp, "issymlinkto", RVAL_TYPE_LIST);`
`623`	`623`
`624`	`624`	`// check if file_result is needed`
`625`		`- if ((s.owners) \|\| (s.min_size) \|\| (s.exec_regex) \|\| (s.exec_program) \|\| (s.filetypes)`
	`625`	`+ if ((s.owners) \|\| (s.groups) \|\| (s.exec_regex) \|\| (s.exec_program) \|\| (s.filetypes)`
`626`	`626`	`\|\| (s.name) \|\| (s.path) \|\| (s.issymlinkto) \|\| (s.perms) \|\| (s.bsdflags))`
`627`	`627`	`{`
`628`	`628`	`entries = true;`