Skip to content

Commit a61dc60

Browse files
committed
update-deps.py: Tweaked which number to bump for php
For php, a bump in what is normally considered the minor version, can contain breaking changes. So for minor package updates, we will only bump the last number. Ticket: ENT-12597 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
1 parent 7d1d8bc commit a61dc60

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/update-deps.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,12 @@ def select_new_version(
138138
log.info(f"Skipping version {new_version} for package {package_name}")
139139
continue
140140

141+
if package_name == "php" and bump_version == "minor":
142+
"""For php, a bump in what is normally considered the minor version,
143+
can contain breaking changes. So for minor package updates, we will
144+
only bump the last number."""
145+
bump_version = "patch"
146+
141147
if bump_version == "major":
142148
return new_version
143149
if bump_version == "minor" and old_split[:1] == new_split[:1]:

0 commit comments

Comments
 (0)