bootstrap-tarballs: Fixed shellcheck issues

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>

Author: larsewi

build-scripts/bootstrap-tarballs

@@ -4,12 +4,12 @@ _dir=$(readlink -e "$(dirname "$0")")
 # refactored a few functions into single file scripts for easier development/debugging, see ENT-12741 and ENT-12595
 # Easier to add a path to a script than source a file of functions.
 export PATH="$_dir"/bin:$PATH
-. `dirname "$0"`/functions
+. "$(dirname "$0")"/functions
 . detect-environment
 . compile-options
 . version
 
-mkdir -p $BASEDIR/output/tarballs
+mkdir -p "$BASEDIR"/output/tarballs
 
 # the first part of the script is not really critical
 set +e
@@ -33,105 +33,105 @@ for repo_spec in cfengine/buildscripts cfengine/core cfengine/masterfiles cfengi
 
   # Convert to uppercase, swap hyphens with underscore and append '_REV'
   # E.g. 'mission-portal' -> 'MISSION_PORTAL_REV'
-  rev_param_name="$(echo $repo | tr '[:lower:]-' '[:upper:]_')_REV"
+  rev_param_name="$(echo "$repo" | tr '[:lower:]-' '[:upper:]_')_REV"
 
   # Try to dereference the result from above and skip the rest of the loop
   # unless the variable is defined.
-  revision="$(echo ${!rev_param_name})" || continue   # dereference
+  revision="${!rev_param_name}" || continue
 
   # remove "origin/" (if any)
   revision="${revision##origin/}"
 
   # Check to see if the resolved variable starts with 'pull/'
   if expr "$revision" : "pull/" >/dev/null; then
     # Extract the revision number. E.g. 'pull/1755' -> '1755'
-    pr_nr="$(echo $revision | cut -d/ -f2)"
+    pr_nr="$(echo "$revision" | cut -d/ -f2)"
 
-    get-github-pull-request-info "$repo_spec" "$pr_nr" >> $BASEDIR/output/PRs
+    get-github-pull-request-info "$repo_spec" "$pr_nr" >> "$BASEDIR"/output/PRs
   fi
 done
 
 # now script failures should fail the script
 set -e
 
 # Build tarball from core repository
-cd $BASEDIR/core
+cd "$BASEDIR"/core
 rm cfengine-3.*.tar.gz || true
-git rev-parse HEAD > $BASEDIR/output/core-commitID
+git rev-parse HEAD > "$BASEDIR"/output/core-commitID
 # Configure in order to run "make dist", deleted later.
 ./configure -C
 make dist
-mv cfengine-3.*.tar.gz $BASEDIR/output/tarballs/
+mv cfengine-3.*.tar.gz "$BASEDIR"/output/tarballs/
 make distclean
 
 # Build tarballs from masterfiles repository
-cd $BASEDIR/masterfiles
+cd "$BASEDIR"/masterfiles
 rm cfengine-masterfiles*.tar.gz || true
-git rev-parse HEAD > $BASEDIR/output/masterfiles-commitID
+git rev-parse HEAD > "$BASEDIR"/output/masterfiles-commitID
 # Configure in order to run "make dist", deleted later.
 ./configure
 make dist         # source tarball
 make tar-package  # package tarball (containing all files as if they were
                   # installed under "prefix".)
-mv cfengine-masterfiles*.tar.gz $BASEDIR/output/tarballs/
+mv cfengine-masterfiles*.tar.gz "$BASEDIR"/output/tarballs/
 make distclean
 
 # Compute a checksum list that can be used to verify the integrity of the
 # tarballs
-cd $BASEDIR/output/tarballs
-sha256sum *.tar.gz > sha256sums.txt
+cd "$BASEDIR"/output/tarballs
+sha256sum -- *.tar.gz > sha256sums.txt
 # Add the BSD (16-bit) checksum of the checksum list to it's filename. This way
 # you can verify the integrity of the checksum list itself.
-CKSUM=`sum sha256sums.txt | cut -d ' ' -f 1`
-mv sha256sums.txt sha256sums.$CKSUM.txt
+CKSUM=$(sum sha256sums.txt | cut -d ' ' -f 1)
+mv sha256sums.txt sha256sums."$CKSUM".txt
 
 # Install javascript dependencies
 (
-if test -f "$BASEDIR/mission-portal/public/scripts/package.json"; then
-  cd $BASEDIR/mission-portal/public/scripts
+if test -f "$BASEDIR"/mission-portal/public/scripts/package.json; then
+  cd "$BASEDIR"/mission-portal/public/scripts
   # display node & npm versions
   npm --version
   node --version
   # install dependencies from npmjs
-  npm ci --prefix $BASEDIR/mission-portal/public/scripts/
+  npm ci --prefix "$BASEDIR"/mission-portal/public/scripts/
   # build react components
-  npm run build --prefix $BASEDIR/mission-portal/public/scripts/
+  npm run build --prefix "$BASEDIR"/mission-portal/public/scripts/
   # remove the packages specified in devDependencies
-  npm prune --omit=dev --prefix $BASEDIR/mission-portal/public/scripts/
+  npm prune --omit=dev --prefix "$BASEDIR"/mission-portal/public/scripts/
 
 fi
 )
 
 # Install PHP dependencies from the mission-portal repository
 (
-if test -f "$BASEDIR/mission-portal/composer.json"; then
-  cd $BASEDIR/mission-portal
+if test -f "$BASEDIR"/mission-portal/composer.json; then
+  cd "$BASEDIR"/mission-portal
   # install PHP dependencies from composer
   php /usr/bin/composer.phar install --no-dev
 fi
 )
 
 # Install PHP dependencies from the nova repository
 (
-if test -f "$BASEDIR/nova/api/http/composer.json"; then
-  cd $BASEDIR/nova/api/http
+if test -f "$BASEDIR"/nova/api/http/composer.json; then
+  cd "$BASEDIR"/nova/api/http
   # install PHP dependencies from composer
   php /usr/bin/composer.phar install --no-dev --ignore-platform-reqs
 fi
 )
 
 # Compile Mission Portal styles
 (
-if test -f "$BASEDIR/mission-portal/public/themes/default/bootstrap/cfengine_theme.less"; then
-  cd $BASEDIR/mission-portal/public/themes/default/bootstrap
+if test -f "$BASEDIR"/mission-portal/public/themes/default/bootstrap/cfengine_theme.less; then
+  cd "$BASEDIR"/mission-portal/public/themes/default/bootstrap
   npx -p less lessc --compress ./cfengine_theme.less ./compiled/css/cfengine.less.css
 fi
 )
 
 # Install LDAP API dependencies
 (
-if test -f "$BASEDIR/mission-portal/ldap/composer.json"; then
-  cd $BASEDIR/mission-portal/ldap
+if test -f "$BASEDIR"/mission-portal/ldap/composer.json; then
+  cd "$BASEDIR"/mission-portal/ldap
   # install PHP dependencies from composer
   php /usr/bin/composer.phar install --no-dev
 fi