From 33c6b816802ff2fd374836b40e3356dec5fcd7ec Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Wed, 23 Apr 2025 10:48:52 +0200 Subject: [PATCH] splitreports: handle empty string chunk_size Handle bot parameter `chunk_size` values empty string, due to missing parameter typing checks --- CHANGELOG.md | 1 + intelmq/lib/splitreports.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 171a71fdb..c0bed9a9a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Please refer to the [NEWS](NEWS.md) for a list of changes which have an affect o ### Core - Drop support for Python 3.8 (fixes #2616, PR#2617 by Sebastian Wagner). +- `intelmq.lib.splitreports`: Handle bot parameter `chunk_size` values empty string, due to missing parameter typing checks (PR#2604 by Sebastian Wagner). ### Development diff --git a/intelmq/lib/splitreports.py b/intelmq/lib/splitreports.py index e34d9c77d..d9522b10f 100644 --- a/intelmq/lib/splitreports.py +++ b/intelmq/lib/splitreports.py @@ -151,7 +151,7 @@ def generate_reports(report_template: Report, infile: BinaryIO, chunk_size: Opti Yields: report: a Report object holding the chunk in the raw field """ - if chunk_size is None: + if not chunk_size: # None, empty string or False report = report_template.copy() data = infile.read() if data: