Skip to content

Commit c16a8d2

Browse files
authored
Merge pull request #2511 from sebix/fix-attach_unzip
mail attachment: Remove deprecated parameter attach_unzip from default parameters
2 parents b3096ba + dfdd9bb commit c16a8d2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
- Fixed timezone issue for collecting reports.
2727
- `intelmq.bots.collectors.shodan.collector_stream` (PR#2492 by Mikk Margus Möll):
2828
- Add `alert` parameter to Shodan stream collector to allow fetching streams by configured alert ID
29+
- `intelmq.bots.collectors.mail._lib`: Remove deprecated parameter `attach_unzip` from default parameters (PR#2511 by Sebastian Wagner).
2930

3031
#### Parsers
3132
- `intelmq.bots.parsers.shadowserver._config`:

intelmq/bots/collectors/mail/_lib.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818

1919
class MailCollectorBot(CollectorBot):
20-
attach_unzip = None
2120
mail_host = None
2221
ssl_ca_certificate = None
2322
mail_user = None
@@ -35,8 +34,8 @@ def init(self):
3534
if imbox is None:
3635
raise MissingDependencyError("imbox")
3736

38-
if self.attach_unzip is not None and not self.extract_files:
39-
self.extract_files = True
37+
if getattr(self, 'attach_unzip', None) is not None and hasattr(self, 'extract_files'):
38+
setattr(self, 'extract_files', True)
4039
self.logger.warning("The parameter 'attach_unzip' is deprecated and will "
4140
"be removed in version 4.0. Use 'extract_files' instead.")
4241

0 commit comments

Comments
 (0)