Skip to content

Add support for ECDSA and Ed25519 algorithms, make key size configurable #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for ECDSA and Ed25519 algorithms, make key size configurable #404

wants to merge 1 commit into from

Conversation

matthewpi
Copy link

Adds the ability to specify the key algorithm (csi.cert-manager.io/key-algorithm) and size (csi.cert-manager.io/key-size).

Algorithms:

  • RSA (2048 <-> 8192)
    • csi.cert-manager.io/key-algorithm: "RSA"
    • csi.cert-manager.io/key-size: "2048" (default if unset)
    • csi.cert-manager.io/key-encoding: "PKCS1" (default if unset)
  • ECDSA (256, 384, 521)
    • csi.cert-manager.io/key-algorithm: "ECDSA"
    • csi.cert-manager.io/key-size: "256" (default if unset)
    • csi.cert-manager.io/key-encoding: "PKCS8" (default if unset)
  • Ed25519
    • csi.cert-manager.io/key-algorithm: "Ed25519"
    • csi.cert-manager.io/key-size: "" (default if unset. Users MAY NOT set a size as Ed25519 doesn't have a configurable size)
    • csi.cert-manager.io/key-encoding: "PKCS8" (default if unset)

Closes #371

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label May 1, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irbekrm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow
Copy link
Contributor

Hi @matthewpi. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify private key algorithm/size
1 participant
@matthewpi