Skip to content

Simplify configuration by creating RBAC by default #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
inteon opened this issue Mar 23, 2023 · 2 comments · May be fixed by #628
Open

Simplify configuration by creating RBAC by default #216

inteon opened this issue Mar 23, 2023 · 2 comments · May be fixed by #628
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@inteon
Copy link
Member

inteon commented Mar 23, 2023 •
edited
Loading

Currently, it is quite complex to configure approver-policy due to all the necessary additional RBAC.

The following RBAC could be added to the Helm chart to simplify usage (easy-mode):

  1. allow approver-policy to approve all issuer types:
- apiGroups: ["cert-manager.io"]
  resources: ["signers"]
  verbs: ["approve"]
...
- kind: ServiceAccount
  name: {{ include "cert-manager-approver-policy.name" . }}
  namespace: {{ .Release.Namespace }}
  1. make all policies applicable to the cert-manager SA by default (use selector for filtering instead):
- apiGroups: ["policy.cert-manager.io"]
  resources: ["certificaterequestpolicies"]
  verbs: ["use"]
...
- kind: ServiceAccount
  name: cert-manager
  namespace: {{ .Release.Namespace }}

cc @wallrj @JoshVanL
@erikgb erikgb mentioned this issue Nov 26, 2023
Merged
@erikgb
Copy link
Contributor

erikgb commented Apr 7, 2025

It seems like 1. was fixed by #416, but as far as I can see 2. still remains unresolved.

/help

@cert-manager-prow
Copy link
Contributor

@erikgb:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

It seems like 1. was fixed by #416, but as far as I can see 2. still remains unresolved.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 7, 2025
@erikgb erikgb linked a pull request Apr 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grant cert-manager RBAC to use all policies by default erikgb/approver-policy
2 participants
@erikgb @inteon