-
Notifications
You must be signed in to change notification settings - Fork 10
Fix slow version queries #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emmachughes
wants to merge
4
commits into
master
Choose a base branch
from
fix-slow-version-queries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix slow version queries #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3174 +/- ##
============================================
+ Coverage 64.19% 68.37% +4.17%
+ Complexity 3325 2247 -1078
============================================
Files 391 209 -182
Lines 14497 10549 -3948
============================================
- Hits 9307 7213 -2094
+ Misses 5190 3336 -1854
🚀 New features to boost your workflow:
|
47710d5 to
1efd86e
Compare
ac3287e to
afbf2e5
Compare
chrieinv
approved these changes
Sep 19, 2025
| /** | ||
| * Used for some admin pages. | ||
| * | ||
| * @return LaravelCollection<int|string, array{ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not match returned structure
edlib-oddarne
approved these changes
Oct 1, 2025
edlib-oddarne
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Content Author
All issues that affect content author (sourcecode/apis/contentauthor)
composer
Pull requests that update Composer packages
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the slow query in CA that leads to a timeout when migrating the
H5P.NDLAThreeImagestuff.This is based on earlier work that was done for SaaS, hence the April date on the migrations. That work removed the
content_versionstable (which had data imported from versionapi) and unused collaboration code in CA (apparently these two had to be removed together). Replacing these tables areparent_idandversion_purposecolumns on each of the content type tables, with appropriate indexes and foreign key constraints.The end result is that looking up the migratable resources against the modified
h5p_contentsnow takes a few seconds on my machine, compared to around a minute prior to the change. The version lookup page in CA admin has been updated to reflect these changes.phpstan failure is a false positive, it passes locally.