Skip to content

Commit b1a9030

Browse files
authored
Merge pull request #11 from cemremengu/travis-cleanup
Cleanup scripts, update readme
2 parents d5f1187 + b27039a commit b1a9030

File tree

5 files changed

+15
-18
lines changed

5 files changed

+15
-18
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ node_js:
88
- "6"
99

1010
script:
11-
- npm run lint-ci
12-
- npm run coveralls -- -c
11+
- npm run lint
12+
- npm run test
1313

1414
env:
1515
- ORACLE_HOME=/u01/app/oracle/product/11.2.0/xe ORACLE_SID=XE OCI_LIB_DIR=/u01/app/oracle/product/11.2.0/xe/lib LD_LIBRARY_PATH=/u01/app/oracle/product/11.2.0/xe/lib

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# fastify-oracle
2-
[![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)
3-
[![Build Status](https://travis-ci.org/cemremengu/fastify-oracle.svg?branch=master)](https://travis-ci.org/cemremengu/fastify-oracle)
4-
[![Coverage Status](https://coveralls.io/repos/github/cemremengu/fastify-oracle/badge.svg?branch=master)](https://coveralls.io/github/cemremengu/fastify-oracle?branch=master) [![Greenkeeper badge](https://badges.greenkeeper.io/cemremengu/fastify-oracle.svg)](https://greenkeeper.io/)
2+
[![Greenkeeper badge](https://badges.greenkeeper.io/cemremengu/fastify-oracle.svg)](https://greenkeeper.io/)
3+
4+
[![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)[![Build Status](https://travis-ci.org/cemremengu/fastify-oracle.svg?branch=master)](https://travis-ci.org/cemremengu/fastify-oracle)
55

66
This module provides access to an Oracle database connection pool via the
77
[oracledb](https://npm.im/oracledb) module. It decorates the [Fastify](https://fastify.io)
@@ -114,5 +114,5 @@ If needed `pool` instance can be accessed via `fastify.oracle[.dbname].pool`
114114
## Acknowledgements
115115

116116
Thanks to
117-
- [James Sumners](https://github.com/jsumners) for his work and transferring his repository to me.
117+
- [James Sumners](https://github.com/jsumners), who is the original author of this plugin, for his work and transferring his repository to me.
118118
- [Vincit](https://github.com/Vincit/travis-oracledb-xe) for his Travis Oracle work.

package.json

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,27 @@
44
"description": "A plugin for Fastify to provide Oracle DB connections",
55
"main": "plugin.js",
66
"scripts": {
7-
"test": "tap 'test/**/*.test.js'",
8-
"test-ci": "tap --cov 'test/**/*.test.js'",
9-
"lint": "standard | snazzy",
10-
"lint-ci": "standard",
11-
"coveralls": "npm run test-ci -- --cov"
7+
"test": "tap --cov 'test/**/*.test.js'",
8+
"lint": "standard | snazzy"
129
},
1310
"precommit": [
1411
"lint",
1512
"test"
1613
],
1714
"repository": {
1815
"type": "git",
19-
"url": "git+ssh://git@github.com/jsumners/fastify-oracle.git"
16+
"url": "git+ssh://git@github.com/cemremengu/fastify-oracle.git"
2017
},
2118
"keywords": [
2219
"fastify",
2320
"oracle"
2421
],
25-
"author": "James Sumners <james.sumners@gmail.com>",
22+
"author": "Cemre Mengu <cemremengu@gmail.com>",
2623
"license": "MIT",
2724
"bugs": {
28-
"url": "https://github.com/jsumners/fastify-oracle/issues"
25+
"url": "https://github.com/cemremengu/fastify-oracle/issues"
2926
},
30-
"homepage": "https://github.com/jsumners/fastify-oracle#readme",
27+
"homepage": "https://github.com/cemremengu/fastify-oracle#readme",
3128
"devDependencies": {
3229
"coveralls": "^3.0.2",
3330
"fastify": "^1.1.0",

test/client.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ test('accepts singleton client', (t) => {
2424
}
2525
}
2626

27-
plugin(fastify, {client: pool}, (err) => {
27+
plugin(fastify, { client: pool }, (err) => {
2828
if (err) t.threw(err)
2929
pool.close()
3030
})
@@ -52,7 +52,7 @@ test('retrieves a cached pool', (t) => {
5252
}
5353
}
5454

55-
plugin(fastify, {poolAlias: 'foo'}, (err) => {
55+
plugin(fastify, { poolAlias: 'foo' }, (err) => {
5656
if (err) t.threw(err)
5757
pool.close()
5858
})

test/pool.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test('creates usable pool from config', (t) => {
2323
password: 'travis',
2424
connectString: 'localhost/xe'
2525
}
26-
plugin(fastify, {pool: opts}, (err) => {
26+
plugin(fastify, { pool: opts }, (err) => {
2727
if (err) t.threw(err)
2828
t.ok(fastify.oracle)
2929
fastify.oracle.getConnection()

0 commit comments

Comments
 (0)