Merge pull request #12 from cemremengu/more-tests

Added more tests

Author: cemremengu

test/client.test.js

@@ -5,7 +5,7 @@ const oracledb = require('oracledb')
 const plugin = require('../plugin')
 
 test('accepts singleton client', (t) => {
-  t.plan(4)
+  t.plan(5)
   oracledb.createPool({
     user: 'travis',
     password: 'travis',
@@ -15,6 +15,7 @@ test('accepts singleton client', (t) => {
     const fastify = {
       decorate (name, obj) {
         t.is(name, 'oracle')
+        t.is(obj.db, oracledb)
         t.is(obj.pool, pool)
       },
 
@@ -32,7 +33,7 @@ test('accepts singleton client', (t) => {
 })
 
 test('retrieves a cached pool', (t) => {
-  t.plan(4)
+  t.plan(5)
   oracledb.createPool({
     user: 'travis',
     password: 'travis',
@@ -43,6 +44,7 @@ test('retrieves a cached pool', (t) => {
     const fastify = {
       decorate (name, obj) {
         t.is(name, 'oracle')
+        t.is(obj.db, oracledb)
         t.is(obj.pool, pool)
       },
 

test/pool.test.js

@@ -3,7 +3,7 @@
 const test = require('tap').test
 const plugin = require('../plugin')
 
-test('creates usable pool from config', (t) => {
+test('creates pool from config', (t) => {
   t.plan(6)
 
   const fastify = {
@@ -28,10 +28,59 @@ test('creates usable pool from config', (t) => {
     t.ok(fastify.oracle)
     fastify.oracle.getConnection()
       .then((conn) => {
-        conn.execute('select 1 from dual')
+        conn.execute('SELECT 1 AS FOO FROM DUAL', { }, { outFormat: fastify.oracle.db.OBJECT })
           .then((result) => {
             t.is(result.rows.length, 1)
-            t.is(result.rows[0][0], 1)
+            t.is(result.rows[0].FOO, 1)
+          })
+          .then(() => conn.close())
+          .catch(t.threw)
+      })
+      .catch(t.threw)
+  })
+})
+
+test('creates named pool from config', (t) => {
+  t.plan(8)
+
+  const fastify = {
+    decorate (name, obj) {
+      t.is(name, 'oracle')
+      this[name] = obj
+    },
+
+    addHook (name, fn) {
+      t.is(name, 'onClose')
+      t.match(fn, /fastify\.oracle\.pool\.close/)
+    }
+  }
+
+  const opts = {
+    user: 'travis',
+    password: 'travis',
+    connectString: 'localhost/xe'
+  }
+  plugin(fastify, { pool: opts, name: 'testdb' }, (err) => {
+    if (err) t.threw(err)
+    t.ok(fastify.oracle)
+    fastify.oracle.getConnection()
+      .then((conn) => {
+        conn.execute('SELECT 1 AS FOO FROM DUAL', { }, { outFormat: fastify.oracle.db.OBJECT })
+          .then((result) => {
+            t.is(result.rows.length, 1)
+            t.is(result.rows[0].FOO, 1)
+          })
+          .then(() => conn.close())
+          .catch(t.threw)
+      })
+      .catch(t.threw)
+
+    fastify.oracle.testdb.getConnection()
+      .then((conn) => {
+        conn.execute('SELECT 1 AS FOO FROM DUAL', { }, { outFormat: fastify.oracle.db.OBJECT })
+          .then((result) => {
+            t.is(result.rows.length, 1)
+            t.is(result.rows[0].FOO, 1)
           })
           .then(() => conn.close())
           .catch(t.threw)